Code review comment for lp:~salgado/bzr/bug-308122

2009/12/23 John A Meinel <email address hidden>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Guilherme Salgado wrote:
>> So, to summarize, this is how it's going to look like, in the end:
>>
>> 1. cmd_unshelve will grow a 'preview' action
>>
>> 2. Unshelver.run() will accept an optional file descriptor, where a diff
>> will be written when the preview action is specified. When the fd is not
>> given it will fall back to ui_factory.make_output_stream().
>
> I'm not sure whether it should be on run() or as a constructor argument.
>
>  unshelver = Unshelver.from_args(..., to_file=self.outf)
> or
>  Unshelver.run(to_file=self.outf)

I haven't looked at the implementation yet but maybe it would be
better to actually have Unshelver.preview(to_file=...)

--
Martin <http://launchpad.net/~mbp/>