Merge lp:~s-matyukevich/charms/trusty/logstash-agent/logstash-agent-1.4.2 into lp:charms/trusty/logstash-agent
Proposed by
Sergey Matyukevich
Status: | Merged |
---|---|
Merged at revision: | 6 |
Proposed branch: | lp:~s-matyukevich/charms/trusty/logstash-agent/logstash-agent-1.4.2 |
Merge into: | lp:charms/trusty/logstash-agent |
Diff against target: |
90 lines (+16/-14) 3 files modified
files/charm/logstash-agent.conf (+2/-3) hooks/common.sh (+4/-4) hooks/install (+10/-7) |
To merge this branch: | bzr merge lp:~s-matyukevich/charms/trusty/logstash-agent/logstash-agent-1.4.2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Review Queue (community) | automated testing | Approve | |
Charles Butler (community) | Approve | ||
Review via email: mp+241382@code.launchpad.net |
Description of the change
Logstash version updated to 1.4.2
To post a comment you must log in.
Reviewers: mp+241382_ code.launchpad. net,
Message:
Please take a look.
Description:
Logstash version updated to 1.4.2
https:/ /code.launchpad .net/~s- matyukevich/ charms/ trusty/ logstash- agent/logstash- agent-1. 4.2/+merge/ 241382
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/172270043/
Affected files (+18, -14 lines): logstash- agent.conf
A [revision details]
M files/charm/
M hooks/common.sh
M hooks/install
Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>
Index: hooks/common.sh
=== modified file 'hooks/common.sh'
--- hooks/common.sh 2012-11-18 22:33:19 +0000
+++ hooks/common.sh 2014-11-10 09:51:05 +0000
@@ -3,9 +3,9 @@
#set -eux # -x for verbose logging to juju debug-log
# Set CONFIG constants /logstash. objects. dreamhost. com/release" "68ac6c953aad02 6752f69ae7c15b1 3f4" /download. elasticsearch. org/logstash/ logstash" "6e6be734392e8c 7d6d55e23d0bd8d 2b3" "/opt/logstash- agent"
-VERSION="1.1.4"
-BASEURL="https:/
-CHECKSUM=
+VERSION="1.4.2"
+BASEURL="https:/
+CHECKSUM=
BASEPATH=
USER="logstash"
HOST=`unit-get private-address`
@@ -15,4 +15,4 @@
# USER=$(config-get user)
# juju-log "Logstash User: ${USER}"
-juju-log "Finished loading config variables"
\ No newline at end of file
+juju-log "Finished loading config variables"
Index: hooks/install /files/ charm/logstash- agent.conf logstash- agent.conf ${BASEPATH} |g" /etc/init/ logstash- agent.conf ${BASEPATH} |g;s|VERSION| ${VERSION} |g" logstash- agent.conf /files/ charm/logstash- ${VERSION} -monolithic. jar ] /files/ charm/logstash- ${VERSION} .tar.gz ] /files/ charm/logstash- ${VERSION} -monolithic. jar /bin/logstash- monolithic. jar /files/ charm/logstash- ${VERSION} .tar.gz /bin/logstash. tar.gz /bin/logstash- monolithic. jar /logstash- ${VERSION} -monolithic. jar /bin/logstash- monolithic. jar" | cut -d " " -f /bin/logstash- monolithic. jar failed" /bin/logstash. tar.gz /logstash- ${VERSION} .tar.gz /bin/logst. ..
=== modified file 'hooks/install'
--- hooks/install 2012-12-02 23:34:57 +0000
+++ hooks/install 2014-11-10 09:51:05 +0000
@@ -11,7 +11,7 @@
# set redis listener
juju-log "Install upstart init script"
install -o root -g root -m 0644 ${HOME}
/etc/init/
-sed -i "s|BASEPATH|
+sed -i "s|BASEPATH|
/etc/init/
juju-log "create logstash user"
[ -z "$(id ${USER})"] && useradd ${USER}
juju-log "create skeleton dir"
@@ -21,18 +21,21 @@
mkdir -p ${BASEPATH}/logs
juju-log "install logstash and create config files"
# Check if a local copy of the jar exists
-if [ -f ${HOME}
+if [ -f ${HOME}
then
- install -o root -g root -m 0644
${HOME}
${BASEPATH}
+ install -o root -g root -m 0644
${HOME}
${BASEPATH}
else
# Download logstash monolithic jar and checksum
- wget -q -O ${BASEPATH}
${BASEURL}
- if [[ $(md5sum "${BASEPATH}
1) != ${CHECKSUM} ]]; then
- juju-log --log-level CRITICAL "Checksum of
${BASEPATH}
+ wget -q -O ${BASEPATH}
${BASEURL}
+ if [[ $(md5sum "${BASEPATH}