Code review comment for lp:~rye/python-oops-tools/local-charset-in-url

Revision history for this message
Robert Collins (lifeless) wrote :

This looks like it should be an else path to the prior case: if we get a bytestring, check that its ascii. (And the right way to do that would be decode('ascii') not an encode.

review: Needs Fixing

« Back to merge proposal