Merge lp:~rye/python-oops-datedir-repo/empty-oops into lp:python-oops-datedir-repo
Proposed by
Roman Yepishev
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | 31 |
Merged at revision: | 30 |
Proposed branch: | lp:~rye/python-oops-datedir-repo/empty-oops |
Merge into: | lp:python-oops-datedir-repo |
Diff against target: |
28 lines (+10/-0) 2 files modified
oops_datedir_repo/serializer.py (+5/-0) oops_datedir_repo/tests/test_serializer.py (+5/-0) |
To merge this branch: | bzr merge lp:~rye/python-oops-datedir-repo/empty-oops |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Review via email: mp+83378@code.launchpad.net |
Description of the change
This checks for length of the oops content before sending it to serializers.
OOPSes of 0 sizes signal about the problem with serializer, but they should not prevent oops loader from working properly.
To post a comment you must log in.
This looks fine modulo pep8 cosmetic stuff (trailing line in file, spurious VWS in the code, and also a missing NEWS entry. I'll add those and land it.