Merge lp:~rye/openshot/stringify-none into lp:openshot/1.4

Proposed by Roman Yepishev
Status: Merged
Merge reported by: Andy Finch
Merged at revision: not available
Proposed branch: lp:~rye/openshot/stringify-none
Merge into: lp:openshot/1.4
Diff against target: 27 lines (+8/-2)
1 file modified
openshot/windows/AddFiles.py (+8/-2)
To merge this branch: bzr merge lp:~rye/openshot/stringify-none
Reviewer Review Type Date Requested Status
Andy Finch Approve
Review via email: mp+110771@code.launchpad.net

Commit message

Stringify None value before storing.

Description of the change

Stringify None.

I guess it is better to have OpenShot store literal None but since all parameters are stored as strings I decided not to change the way it works.

To post a comment you must log in.
Revision history for this message
Andy Finch (fincha) wrote :

Thanks, this has now been applied to the trunk.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'openshot/windows/AddFiles.py'
2--- openshot/windows/AddFiles.py 2012-04-10 20:12:04 +0000
3+++ openshot/windows/AddFiles.py 2012-06-18 10:27:20 +0000
4@@ -117,7 +117,10 @@
5 messagebox.show(_("Error"), _("There was an error importing the selected file(s)."))
6
7 #set the last used folder
8- preferences.Settings.app_state["import_folder"] = self.frmAddFiles.get_current_folder()
9+ current_folder = self.frmAddFiles.get_current_folder()
10+ if current_folder is None:
11+ current_folder = "None"
12+ preferences.Settings.app_state["import_folder"] = current_folder
13
14 # clear and destroy this dialog
15 self.form.import_files_dialog = None
16@@ -164,7 +167,10 @@
17 messagebox.show(_("Error"), _("There was an error importing the selected file(s)."))
18
19 #set the last used folder
20- preferences.Settings.app_state["import_folder"] = self.frmAddFiles.get_current_folder()
21+ current_folder = self.frmAddFiles.get_current_folder()
22+ if current_folder is None:
23+ current_folder = "None"
24+ preferences.Settings.app_state["import_folder"] = current_folder
25
26
27 self.frmAddFiles.destroy()

Subscribers

People subscribed via source and target branches

to status/vote changes: