Merge lp:~rvb/usso/cleanup into lp:usso
Proposed by
Raphaël Badin
Status: | Merged |
---|---|
Approved by: | Vincenzo Di Somma |
Approved revision: | 14 |
Merge reported by: | Raphaël Badin |
Merged at revision: | not available |
Proposed branch: | lp:~rvb/usso/cleanup |
Merge into: | lp:usso |
Diff against target: |
70 lines (+30/-12) 2 files modified
usso.go (+28/-11) usso_test.go (+2/-1) |
To merge this branch: | bzr merge lp:~rvb/usso/cleanup |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincenzo Di Somma (community) | Approve | ||
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+144093@code.launchpad.net |
Commit message
Refactor Sign method to make it more readable and extract utility methods.
- refactor how the timestamp and the nonce are generated to use strconv.Itoa everywhere (instead of using "strconv.Itoa" plus "strconv.
- using 100000000 as the bound given to rand.Intn is not inclusive.
To post a comment you must log in.
Nice!