Storm

Merge lp:~rvb/storm/storm-0slice-bug-872086-tests into lp:storm

  1. storm-0slice-bug-872086-tests
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Thomas Herve
Approved revision: 418
Merged at revision: 419
Proposed branch: lp:~rvb/storm/storm-0slice-bug-872086-tests
Merge into: lp:storm
Diff against target: 0 lines
To merge this branch: bzr merge lp:~rvb/storm/storm-0slice-bug-872086-tests
Reviewer Review Type Date Requested Status
Thomas Herve (community) Approve
Gavin Panella Approve
Review via email: mp+79658@code.launchpad.net

Commit message

Add tests to make sure slicing with None works as expected.

Description of the change

This branch adds a few tests to make sure that slicing SQLObjectResultSet objects works even when None is used as a slicing parameter.

= Tests =

tests/sqlobject.py test_result_set_count_sliced_none
tests/sqlobject.py test_result_set_count_sliced_start_none
tests/sqlobject.py test_result_set_count_sliced_end_none

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve
Revision history for this message
Thomas Herve (therve) wrote :

[1] I'll change the second test to check result[None:1], otherwise we don't know if the second parameters is used or not.

+1!

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

> [1] I'll change the second test to check result[None:1], otherwise we don't
> know if the second parameters is used or not.
>
> +1!

Good point, I've done it. Thanks for the review.

lp:~rvb/storm/storm-0slice-bug-872086-tests updated
419. By Raphaël Badin

Fix test_result_set_count_sliced_start_none to make sure that slice.end is used.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: