Merge lp:~rvb/maas/write_dns_config-command into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 1303 |
Proposed branch: | lp:~rvb/maas/write_dns_config-command |
Merge into: | lp:~maas-committers/maas/trunk |
Prerequisite: | lp:~rvb/maas/bug-1067977-dns-conf |
Diff against target: |
108 lines (+87/-1) 3 files modified
src/maasserver/management/commands/set_up_dns.py (+1/-1) src/maasserver/management/commands/write_dns_config.py (+34/-0) src/maasserver/tests/test_commands_write_dns_config.py (+52/-0) |
To merge this branch: | bzr merge lp:~rvb/maas/write_dns_config-command |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+131030@code.launchpad.net |
Commit message
Add a command to write the full DNS config. This will be called by the postinst script of maas-dns.
Description of the change
Add a command to write the full DNS config. This will be called by the postinst script of maas-dns.
maas-dns will call:
- Call the command 'set_up_dns' (set up all the RNDC config)
- restart bind (at this stage MAAS still cannot restart bind itself as the rndc key is still not loaded)
- Call the command 'write_dns_config'
The main goal of this fix is to cover for the following workflow:
1. the user configures an interface to manage DNS
2. looking at the logs, he suddenly realizes that he forgot to install the maas-dns package
3. the users installs maas-dns
At this stage, it is important that maas-dns calls the command write_dns_config so that the confi done in 1. is applied to the DNS config.
One small thing: in write_dns_config.py your help string uses the term “MAAS server.” I guess that should be “region controller” now. Or even just “region.”
Jeroen