Merge lp:~rvb/maas/use-reverse into lp:~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 659 |
Proposed branch: | lp:~rvb/maas/use-reverse |
Merge into: | lp:~maas-committers/maas/trunk |
Prerequisite: | lp:~rvb/maas/pxe-off-preseed |
Diff against target: |
286 lines (+60/-60) 2 files modified
src/maas/urls.py (+1/-1) src/metadataserver/tests/test_api.py (+59/-59) |
To merge this branch: | bzr merge lp:~rvb/maas/use-reverse |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Francesco Banconi (community) | code* | Approve | |
Review via email: mp+111240@code.launchpad.net |
Commit message
Use Django's reverse in src/metadataser
Description of the change
This branch fixes a problem I spotted when I was working on the pre-req branch.
The metadata application should be hooked up (in src/maas/urls.py) like this:
urlpatterns = patterns('',
url(r'^', include(
url(
)
Note the trailing slash at the end of '^metadata/'. Otherwise, reverse(...) does not return a correct path.
See https:/
I refactored src/metadataser
Looks good.