Merge lp:~rvb/maas/use-fqdn into lp:~maas-committers/maas/trunk
Proposed by
Raphaël Badin
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Raphaël Badin | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 1318 | ||||
Proposed branch: | lp:~rvb/maas/use-fqdn | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Prerequisite: | lp:~rvb/maas/add-fqdn | ||||
Diff against target: |
194 lines (+113/-7) 4 files modified
src/maasserver/api.py (+17/-1) src/maasserver/models/node.py (+1/-1) src/maasserver/models/nodegroup.py (+7/-5) src/maasserver/tests/test_api.py (+88/-0) |
||||
To merge this branch: | bzr merge lp:~rvb/maas/use-fqdn | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Julian Edwards (community) | Approve | ||
Jeroen T. Vermeulen | Pending | ||
Review via email: mp+131860@code.launchpad.net |
Commit message
Use node.fqdn in the api in lieu of the hostname.
Description of the change
Use node.fqdn in the api in lieu of the hostname.
= Notes =
You might wonder why I had to do "model = Node" in AnonNodesHandler: this is to make sure that this handler is registered as the node handler used by anon requests so that the hostname replacement trick also works for anon requests. The side effect is that resource_uri is now included in the anon registration response but I think this is an improvement.
To post a comment you must log in.
As discussed, add a test to show that having a hostname without the domain appended still returns the hostname + domain name from the nodegroup.
cheers!