Code review comment for lp:~rvb/maas/ui-update-fqdn

Revision history for this message
Raphaƫl Badin (rvb) wrote :

Thanks for the review!

> Hmm this might be needs-fixing, but I'll let you explain yourself - where are
> the tests for the changed node_view?
> I'll approve for now on the basis you either know that it's tested implicitly
> elsewhere or that you'll add a test.

That page is indeed massively tested already but I added 2 tests to make sure that the FQDN is properly displayed.

> Some other minor points:
>
> 9 + label="Hostname", help_text=(
>
> s/Hostname/Host name/
>
> ie two words (in multiple places)
>
> 14 + "does not manage DNS, then the hostname is the FQDN."))

Done.

> I'd say: "the host name as entered will be the FQDN."

Done.

« Back to merge proposal