Merge lp:~rvb/maas/test-model-cleanup into lp:~maas-committers/maas/trunk

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 632
Proposed branch: lp:~rvb/maas/test-model-cleanup
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 26 lines (+2/-2)
1 file modified
src/maasserver/testing/tests/test_module.py (+2/-2)
To merge this branch: bzr merge lp:~rvb/maas/test-model-cleanup
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+109854@code.launchpad.net

Commit message

Test model.py structure cleanup.

Description of the change

Tiny cleanup branch. I came across a tiny weirdness when working on something else: src/maasserver/testing/models.py contains the model class used in tests, therefore it should be in src/maasserver/testing/tests/ and not in src/maasserver/testing.

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== renamed file 'src/maasserver/testing/models.py' => 'src/maasserver/testing/tests/models.py'
2=== modified file 'src/maasserver/testing/tests/test_module.py'
3--- src/maasserver/testing/tests/test_module.py 2012-04-27 12:38:18 +0000
4+++ src/maasserver/testing/tests/test_module.py 2012-06-12 14:12:04 +0000
5@@ -25,11 +25,11 @@
6 reload_objects,
7 )
8 from maasserver.testing.factory import factory
9-from maasserver.testing.models import TestModel
10 from maasserver.testing.testcase import (
11 TestCase,
12 TestModelTestCase,
13 )
14+from maasserver.testing.tests.models import TestModel
15 from provisioningserver.testing import fakeapi
16
17 # Horrible kludge. Works around a bug where delete() does not work on
18@@ -82,7 +82,7 @@
19 class TestHelpers(TestModelTestCase):
20 """Test helper functions."""
21
22- app = 'maasserver.testing'
23+ app = 'maasserver.testing.tests'
24
25 def test_extract_redirect_extracts_redirect_location(self):
26 url = factory.getRandomString()