Merge lp:~rvb/maas/storage-unit-bug-1387431 into lp:~maas-committers/maas/trunk

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 3322
Proposed branch: lp:~rvb/maas/storage-unit-bug-1387431
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
src/maasserver/forms.py (+1/-1)
To merge this branch: bzr merge lp:~rvb/maas/storage-unit-bug-1387431
Reviewer Review Type Date Requested Status
Christian Reis (community) Approve
Julian Edwards (community) Approve
Review via email: mp+240110@code.launchpad.net

Commit message

Fix storage unit on the node edit page.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

:)

review: Approve
Revision history for this message
Christian Reis (kiko) wrote :

Didn't we just agree we shouldn't do this?

review: Needs Information
Revision history for this message
Raphaël Badin (rvb) wrote :

> Didn't we just agree we shouldn't do this?

That's not what I remember: we went back and forth on this because the original bug missed the main problem. The summary is this: the node listing page uses GB (probably to make the column more compact) but the information stored (and used on the node edit/view page) is MB, hence this fix.

What do you suggest we do instead?

Revision history for this message
Christian Reis (kiko) wrote :

Fine, fine. I was thinking back to the fact that we had said we would reuse the logic in the node listing in this page, but if you leave the bug open we can get to that later.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/forms.py'
2--- src/maasserver/forms.py 2014-10-30 11:08:43 +0000
3+++ src/maasserver/forms.py 2014-10-30 12:48:28 +0000
4@@ -616,7 +616,7 @@
5 memory = forms.IntegerField(
6 required=False, initial=0, label="Memory (MB)")
7 storage = forms.IntegerField(
8- required=False, initial=0, label="Disk space (GB)")
9+ required=False, initial=0, label="Disk space (MB)")
10
11 class Meta:
12 model = Node