MAAS

Merge lp:~rvb/maas/msg-bug-1424080 into lp:~maas-committers/maas/trunk

  1. msg-bug-1424080
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 3830
Proposed branch: lp:~rvb/maas/msg-bug-1424080
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 14 lines (+3/-1)
1 file modified
src/metadataserver/api.py (+3/-1)
To merge this branch: bzr merge lp:~rvb/maas/msg-bug-1424080
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+256939@code.launchpad.net

Commit message

Fix 'installation failed' message: the previous message was misleading.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good but I think the message could be a little better.

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

Thanks for the review. I've updated the message.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/metadataserver/api.py'
2--- src/metadataserver/api.py 2015-03-25 15:33:23 +0000
3+++ src/metadataserver/api.py 2015-04-21 14:20:01 +0000
4@@ -302,7 +302,9 @@
5 elif node.status == NODE_STATUS.DEPLOYING:
6 self._store_installation_results(node, request)
7 if status == SIGNAL_STATUS.FAILED:
8- node.mark_failed("Failed to get installation result.")
9+ node.mark_failed(
10+ "Installation failed (refer to the installation log "
11+ "for more information).")
12 target_status = None
13 elif node.status == NODE_STATUS.DISK_ERASING:
14 if status == SIGNAL_STATUS.OK: