Merge lp:~rvb/maas/fix-region-admin-cli into lp:~maas-maintainers/maas/packaging

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 302
Proposed branch: lp:~rvb/maas/fix-region-admin-cli
Merge into: lp:~maas-maintainers/maas/packaging
Diff against target: 43 lines (+20/-8)
2 files modified
debian/changelog (+4/-0)
debian/extras/maas-region-admin (+16/-8)
To merge this branch: bzr merge lp:~rvb/maas/fix-region-admin-cli
Reviewer Review Type Date Requested Status
Graham Binns (community) Approve
Review via email: mp+233901@code.launchpad.net

Commit message

Rewrite debian/extras/maas-region-admin so that it doesn't use django-admin which prints garbage to stdout.

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) :
review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

Attempt to merge into lp:~maas-maintainers/maas/packaging failed due to conflicts:

text conflict in debian/changelog

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-09-09 21:08:50 +0000
3+++ debian/changelog 2014-09-10 07:55:12 +0000
4@@ -23,6 +23,10 @@
5 * debian/maas-region-controller-min.install: Install
6 maas-generate-winrm-cert script.
7
8+ [ Raphaël Badin ]
9+ * debian/extras/maas-region-admin: Bypass django-admin as it prints
10+ spurious messages to stdout (LP: #1365130).
11+
12 -- Andres Rodriguez <andreserl@ubuntu.com> Thu, 21 Aug 2014 19:36:30 -0400
13
14 maas (1.7.0~beta1+bzr2781-0ubuntu1) utopic; urgency=medium
15
16=== modified file 'debian/extras/maas-region-admin'
17--- debian/extras/maas-region-admin 2014-02-12 05:46:08 +0000
18+++ debian/extras/maas-region-admin 2014-09-10 07:55:12 +0000
19@@ -1,8 +1,16 @@
20-#!/bin/sh
21-if [ "$(id -u)" != "0" ]; then
22- echo "This utility may only be run as root." 1>&2
23- exit 1
24-fi
25-export PYTHONPATH="/usr/share/maas${PYTHONPATH:+:}${PYTHONPATH}"
26-export DJANGO_SETTINGS_MODULE="maas.settings"
27-exec /usr/bin/django-admin "$@"
28+#!/usr/bin/python
29+import os
30+import sys
31+
32+user_id = os.getuid()
33+if user_id != 0:
34+ print("This utility may only be run as root.")
35+ sys.exit(1)
36+
37+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "maas.settings")
38+sys.path.append('/usr/share/maas')
39+
40+from django.core import management
41+
42+if __name__ == "__main__":
43+ management.execute_from_command_line()

Subscribers

People subscribed via source and target branches