Merge lp:~rvb/maas/fix-django-1.6-incomp into lp:~maas-committers/maas/trunk

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 1749
Proposed branch: lp:~rvb/maas/fix-django-1.6-incomp
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 123 lines (+11/-11)
8 files modified
contrib/wsgi.py (+2/-2)
src/maas/urls.py (+1/-1)
src/maasserver/tests/test_views.py (+1/-1)
src/maasserver/urls.py (+1/-1)
src/maasserver/urls_api.py (+1/-1)
src/maasserver/urls_combo.py (+1/-1)
src/metadataserver/urls.py (+1/-1)
versions.cfg (+3/-3)
To merge this branch: bzr merge lp:~rvb/maas/fix-django-1.6-incomp
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+197229@code.launchpad.net

Commit message

Fix a couple of incompatibilities with Django 1.6.

Description of the change

Based on Diogo's report this branch fixes 2 Django 1.6-incompatibilities:
- Fix contrib/wsgi.py to define DJANGO_SETTINGS_MODULE before django.core.handlers.wsgi gets imported.
- s/django.conf.urls.defaults/from django.conf.urls/.

In addition, it fixes 2 other Django 1.6-incompatibilities:
- Upgrade selenium's version so that the tests can be run with the version of Firefox present in Trusty.
- upgrade django-nose to 1.2 (previous versions are not Django-1.6 compatible).

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

 review: approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'contrib/wsgi.py'
2--- contrib/wsgi.py 2013-10-07 09:12:40 +0000
3+++ contrib/wsgi.py 2013-11-29 16:10:24 +0000
4@@ -19,14 +19,14 @@
5 import os
6 import sys
7
8-import django.core.handlers.wsgi
9-
10
11 current_path = os.path.dirname(os.path.abspath(__file__))
12 sys.path.append(current_path)
13
14 os.environ['DJANGO_SETTINGS_MODULE'] = 'maas.settings'
15+import django.core.handlers.wsgi
16 application = django.core.handlers.wsgi.WSGIHandler()
17
18+
19 from maasserver.start_up import start_up
20 start_up()
21
22=== modified file 'src/maas/urls.py'
23--- src/maas/urls.py 2013-10-18 16:57:37 +0000
24+++ src/maas/urls.py 2013-11-29 16:10:24 +0000
25@@ -15,7 +15,7 @@
26 __all__ = []
27
28 from django.conf import settings
29-from django.conf.urls.defaults import (
30+from django.conf.urls import (
31 include,
32 patterns,
33 url,
34
35=== modified file 'src/maasserver/tests/test_views.py'
36--- src/maasserver/tests/test_views.py 2013-10-18 16:57:37 +0000
37+++ src/maasserver/tests/test_views.py 2013-11-29 16:10:24 +0000
38@@ -18,7 +18,7 @@
39 from random import randint
40 from xmlrpclib import Fault
41
42-from django.conf.urls.defaults import patterns
43+from django.conf.urls import patterns
44 from django.core.exceptions import PermissionDenied
45 from django.core.urlresolvers import reverse
46 from django.http import Http404
47
48=== modified file 'src/maasserver/urls.py'
49--- src/maasserver/urls.py 2013-10-15 11:51:48 +0000
50+++ src/maasserver/urls.py 2013-11-29 16:10:24 +0000
51@@ -15,7 +15,7 @@
52 __all__ = []
53
54
55-from django.conf.urls.defaults import (
56+from django.conf.urls import (
57 include,
58 patterns,
59 url,
60
61=== modified file 'src/maasserver/urls_api.py'
62--- src/maasserver/urls_api.py 2013-10-24 23:03:11 +0000
63+++ src/maasserver/urls_api.py 2013-11-29 16:10:24 +0000
64@@ -14,7 +14,7 @@
65 __metaclass__ = type
66 __all__ = []
67
68-from django.conf.urls.defaults import (
69+from django.conf.urls import (
70 patterns,
71 url,
72 )
73
74=== modified file 'src/maasserver/urls_combo.py'
75--- src/maasserver/urls_combo.py 2013-10-18 16:57:37 +0000
76+++ src/maasserver/urls_combo.py 2013-11-29 16:10:24 +0000
77@@ -16,7 +16,7 @@
78
79
80 from django.conf import settings
81-from django.conf.urls.defaults import (
82+from django.conf.urls import (
83 patterns,
84 url,
85 )
86
87=== modified file 'src/metadataserver/urls.py'
88--- src/metadataserver/urls.py 2013-10-07 09:12:40 +0000
89+++ src/metadataserver/urls.py 2013-11-29 16:10:24 +0000
90@@ -16,7 +16,7 @@
91 'urlpatterns',
92 ]
93
94-from django.conf.urls.defaults import (
95+from django.conf.urls import (
96 patterns,
97 url,
98 )
99
100=== modified file 'versions.cfg'
101--- versions.cfg 2013-09-24 22:44:50 +0000
102+++ versions.cfg 2013-11-29 16:10:24 +0000
103@@ -31,9 +31,9 @@
104 buildout-versions = 1.7
105 coverage = 3.5.1
106 distribute = 0.6.34
107-django-nose = 0.1.3
108+django-nose = 1.2
109 fixtures = 0.3.8
110-nose = 1.1.2
111+nose = 1.3
112 nose-subunit = 0.2
113 python-subunit = 0.0.7
114 rabbitfixture = 0.3.4
115@@ -117,7 +117,7 @@
116 # Required by:
117 # sst==0.2.2
118 # saucelabsfixture=0.1
119-selenium = 2.32
120+selenium = 2.37.2
121
122 # Required by:
123 # sst==0.2.2