Merge lp:~rvb/maas/bug-import-eph-crash into lp:~maas-committers/maas/trunk

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: no longer in the source branch.
Merged at revision: 2145
Proposed branch: lp:~rvb/maas/bug-import-eph-crash
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 18 lines (+3/-2)
1 file modified
src/provisioningserver/import_images/ephemerals_script.py (+3/-2)
To merge this branch: bzr merge lp:~rvb/maas/bug-import-eph-crash
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+211673@code.launchpad.net

Commit message

Fix calls to install_image_from_simplestreams in the ephemerals import script: install_image_from_simplestreams() now takes a 'label' parameter.

Description of the change

This is a fallout from https://code.launchpad.net/~jtv/maas/label-level-in-boot-image-dir-tree/+merge/210740. The problem was in an area of the script that is still untested. This is why we didn't see the failure earlier and why this fix doesn't include a test.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/provisioningserver/import_images/ephemerals_script.py'
2--- src/provisioningserver/import_images/ephemerals_script.py 2014-03-14 04:24:47 +0000
3+++ src/provisioningserver/import_images/ephemerals_script.py 2014-03-19 07:29:38 +0000
4@@ -311,11 +311,12 @@
5 # right now, although it might some day for HWE
6 # kernels.
7 install_image_from_simplestreams(
8- target_dir, release=release, arch=arch,
9+ target_dir, release=release, label=label, arch=arch,
10 temp_location=self._simplestreams_path())
11 if arch == 'armhf':
12 install_image_from_simplestreams(
13- target_dir, release=release, arch=arch, subarch='highbank',
14+ target_dir, release=release, label=label, arch=arch,
15+ subarch='highbank',
16 temp_location=self._simplestreams_path())
17
18 tgt_conf_path = os.path.join(target_dir, 'tgt.conf')