Merge lp:~rvb/maas/agent-bug-1239488 into lp:~maas-committers/maas/trunk
- agent-bug-1239488
- Merge into trunk
Proposed by
Raphaël Badin
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Raphaël Badin | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 1708 | ||||
Proposed branch: | lp:~rvb/maas/agent-bug-1239488 | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
238 lines (+222/-0) 2 files modified
src/maasserver/migrations/0058_add_agent_name_to_node.py (+220/-0) src/maasserver/models/node.py (+2/-0) |
||||
To merge this branch: | bzr merge lp:~rvb/maas/agent-bug-1239488 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Review via email: mp+191140@code.launchpad.net |
Commit message
Add an agent_name char field of size 255 with a default value of ''.
Description of the change
The empty string is the default value for this field so that upgrading will set agent_name to '' for all the existing nodes.
To post a comment you must log in.
Revision history for this message
Raphaël Badin (rvb) wrote : | # |
> I can see, by running `make syncdb`, that agent_name cannot be null, but can
> you make that explicit in the code with a null=False?
All right, done.
Thanks for the review!
Revision history for this message
MAAS Lander (maas-lander) wrote : | # |
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1 | === added file 'src/maasserver/migrations/0058_add_agent_name_to_node.py' |
2 | --- src/maasserver/migrations/0058_add_agent_name_to_node.py 1970-01-01 00:00:00 +0000 |
3 | +++ src/maasserver/migrations/0058_add_agent_name_to_node.py 2013-10-15 11:42:28 +0000 |
4 | @@ -0,0 +1,220 @@ |
5 | +# -*- coding: utf-8 -*- |
6 | +import datetime |
7 | + |
8 | +from django.db import models |
9 | +from south.db import db |
10 | +from south.v2 import SchemaMigration |
11 | + |
12 | + |
13 | +class Migration(SchemaMigration): |
14 | + |
15 | + def forwards(self, orm): |
16 | + # Adding field 'Node.agent_name' |
17 | + db.add_column(u'maasserver_node', 'agent_name', |
18 | + self.gf('django.db.models.fields.CharField')(default=u'', max_length=255, null=True, blank=True), |
19 | + keep_default=False) |
20 | + |
21 | + |
22 | + def backwards(self, orm): |
23 | + # Deleting field 'Node.agent_name' |
24 | + db.delete_column(u'maasserver_node', 'agent_name') |
25 | + |
26 | + |
27 | + models = { |
28 | + u'auth.group': { |
29 | + 'Meta': {'object_name': 'Group'}, |
30 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
31 | + 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '80'}), |
32 | + 'permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'}) |
33 | + }, |
34 | + u'auth.permission': { |
35 | + 'Meta': {'ordering': "(u'content_type__app_label', u'content_type__model', u'codename')", 'unique_together': "((u'content_type', u'codename'),)", 'object_name': 'Permission'}, |
36 | + 'codename': ('django.db.models.fields.CharField', [], {'max_length': '100'}), |
37 | + 'content_type': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['contenttypes.ContentType']"}), |
38 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
39 | + 'name': ('django.db.models.fields.CharField', [], {'max_length': '50'}) |
40 | + }, |
41 | + u'auth.user': { |
42 | + 'Meta': {'object_name': 'User'}, |
43 | + 'date_joined': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}), |
44 | + 'email': ('django.db.models.fields.EmailField', [], {'unique': 'True', 'max_length': '75', 'blank': 'True'}), |
45 | + 'first_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}), |
46 | + 'groups': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['auth.Group']", 'symmetrical': 'False', 'blank': 'True'}), |
47 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
48 | + 'is_active': ('django.db.models.fields.BooleanField', [], {'default': 'True'}), |
49 | + 'is_staff': ('django.db.models.fields.BooleanField', [], {'default': 'False'}), |
50 | + 'is_superuser': ('django.db.models.fields.BooleanField', [], {'default': 'False'}), |
51 | + 'last_login': ('django.db.models.fields.DateTimeField', [], {'default': 'datetime.datetime.now'}), |
52 | + 'last_name': ('django.db.models.fields.CharField', [], {'max_length': '30', 'blank': 'True'}), |
53 | + 'password': ('django.db.models.fields.CharField', [], {'max_length': '128'}), |
54 | + 'user_permissions': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['auth.Permission']", 'symmetrical': 'False', 'blank': 'True'}), |
55 | + 'username': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '30'}) |
56 | + }, |
57 | + u'contenttypes.contenttype': { |
58 | + 'Meta': {'ordering': "('name',)", 'unique_together': "(('app_label', 'model'),)", 'object_name': 'ContentType', 'db_table': "'django_content_type'"}, |
59 | + 'app_label': ('django.db.models.fields.CharField', [], {'max_length': '100'}), |
60 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
61 | + 'model': ('django.db.models.fields.CharField', [], {'max_length': '100'}), |
62 | + 'name': ('django.db.models.fields.CharField', [], {'max_length': '100'}) |
63 | + }, |
64 | + u'maasserver.bootimage': { |
65 | + 'Meta': {'unique_together': "((u'nodegroup', u'architecture', u'subarchitecture', u'release', u'purpose'),)", 'object_name': 'BootImage'}, |
66 | + 'architecture': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
67 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
68 | + 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}), |
69 | + 'purpose': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
70 | + 'release': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
71 | + 'subarchitecture': ('django.db.models.fields.CharField', [], {'max_length': '255'}) |
72 | + }, |
73 | + u'maasserver.componenterror': { |
74 | + 'Meta': {'object_name': 'ComponentError'}, |
75 | + 'component': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '40'}), |
76 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
77 | + 'error': ('django.db.models.fields.CharField', [], {'max_length': '1000'}), |
78 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
79 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
80 | + }, |
81 | + u'maasserver.config': { |
82 | + 'Meta': {'object_name': 'Config'}, |
83 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
84 | + 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
85 | + 'value': ('maasserver.fields.JSONObjectField', [], {'null': 'True'}) |
86 | + }, |
87 | + u'maasserver.dhcplease': { |
88 | + 'Meta': {'object_name': 'DHCPLease'}, |
89 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
90 | + 'ip': ('django.db.models.fields.IPAddressField', [], {'unique': 'True', 'max_length': '15'}), |
91 | + 'mac': ('maasserver.fields.MACAddressField', [], {}), |
92 | + 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}) |
93 | + }, |
94 | + u'maasserver.downloadprogress': { |
95 | + 'Meta': {'object_name': 'DownloadProgress'}, |
96 | + 'bytes_downloaded': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}), |
97 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
98 | + 'error': ('django.db.models.fields.CharField', [], {'max_length': '1000', 'blank': 'True'}), |
99 | + 'filename': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
100 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
101 | + 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}), |
102 | + 'size': ('django.db.models.fields.IntegerField', [], {'null': 'True', 'blank': 'True'}), |
103 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
104 | + }, |
105 | + u'maasserver.filestorage': { |
106 | + 'Meta': {'unique_together': "((u'filename', u'owner'),)", 'object_name': 'FileStorage'}, |
107 | + 'content': ('metadataserver.fields.BinaryField', [], {'blank': 'True'}), |
108 | + 'filename': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
109 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
110 | + 'key': ('django.db.models.fields.CharField', [], {'default': "u'b361ce96-358e-11e3-a890-9c4e363b1c94'", 'unique': 'True', 'max_length': '36'}), |
111 | + 'owner': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['auth.User']", 'null': 'True', 'blank': 'True'}) |
112 | + }, |
113 | + u'maasserver.macaddress': { |
114 | + 'Meta': {'object_name': 'MACAddress'}, |
115 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
116 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
117 | + 'mac_address': ('maasserver.fields.MACAddressField', [], {'unique': 'True'}), |
118 | + 'node': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.Node']"}), |
119 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
120 | + }, |
121 | + u'maasserver.node': { |
122 | + 'Meta': {'object_name': 'Node'}, |
123 | + 'after_commissioning_action': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
124 | + 'agent_name': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'null': 'True', 'blank': 'True'}), |
125 | + 'architecture': ('django.db.models.fields.CharField', [], {'default': "u'i386/generic'", 'max_length': '31'}), |
126 | + 'cpu_count': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
127 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
128 | + 'distro_series': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '20', 'null': 'True', 'blank': 'True'}), |
129 | + 'error': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}), |
130 | + 'hostname': ('django.db.models.fields.CharField', [], {'default': "u''", 'unique': 'True', 'max_length': '255', 'blank': 'True'}), |
131 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
132 | + 'memory': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
133 | + 'netboot': ('django.db.models.fields.BooleanField', [], {'default': 'True'}), |
134 | + 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']", 'null': 'True'}), |
135 | + 'owner': ('django.db.models.fields.related.ForeignKey', [], {'default': 'None', 'to': u"orm['auth.User']", 'null': 'True', 'blank': 'True'}), |
136 | + 'power_parameters': ('maasserver.fields.JSONObjectField', [], {'default': "u''", 'blank': 'True'}), |
137 | + 'power_type': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '10', 'blank': 'True'}), |
138 | + 'routers': ('djorm_pgarray.fields.ArrayField', [], {'default': 'None', 'dbtype': "u'macaddr'", 'null': 'True', 'blank': 'True'}), |
139 | + 'status': ('django.db.models.fields.IntegerField', [], {'default': '0', 'max_length': '10'}), |
140 | + 'storage': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
141 | + 'system_id': ('django.db.models.fields.CharField', [], {'default': "u'node-b3601538-358e-11e3-a890-9c4e363b1c94'", 'unique': 'True', 'max_length': '41'}), |
142 | + 'tags': ('django.db.models.fields.related.ManyToManyField', [], {'to': u"orm['maasserver.Tag']", 'symmetrical': 'False'}), |
143 | + 'token': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Token']", 'null': 'True'}), |
144 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
145 | + }, |
146 | + u'maasserver.nodegroup': { |
147 | + 'Meta': {'object_name': 'NodeGroup'}, |
148 | + 'api_key': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '18'}), |
149 | + 'api_token': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Token']", 'unique': 'True'}), |
150 | + 'cluster_name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '100', 'blank': 'True'}), |
151 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
152 | + 'dhcp_key': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}), |
153 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
154 | + 'maas_url': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}), |
155 | + 'name': ('django.db.models.fields.CharField', [], {'max_length': '80', 'blank': 'True'}), |
156 | + 'status': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
157 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}), |
158 | + 'uuid': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '36'}) |
159 | + }, |
160 | + u'maasserver.nodegroupinterface': { |
161 | + 'Meta': {'unique_together': "((u'nodegroup', u'interface'),)", 'object_name': 'NodeGroupInterface'}, |
162 | + 'broadcast_ip': ('django.db.models.fields.GenericIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}), |
163 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
164 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
165 | + 'interface': ('django.db.models.fields.CharField', [], {'default': "u''", 'max_length': '255', 'blank': 'True'}), |
166 | + 'ip': ('django.db.models.fields.GenericIPAddressField', [], {'max_length': '39'}), |
167 | + 'ip_range_high': ('django.db.models.fields.GenericIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}), |
168 | + 'ip_range_low': ('django.db.models.fields.GenericIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}), |
169 | + 'management': ('django.db.models.fields.IntegerField', [], {'default': '0'}), |
170 | + 'nodegroup': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['maasserver.NodeGroup']"}), |
171 | + 'router_ip': ('django.db.models.fields.GenericIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}), |
172 | + 'subnet_mask': ('django.db.models.fields.GenericIPAddressField', [], {'default': 'None', 'max_length': '39', 'null': 'True', 'blank': 'True'}), |
173 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
174 | + }, |
175 | + u'maasserver.sshkey': { |
176 | + 'Meta': {'unique_together': "((u'user', u'key'),)", 'object_name': 'SSHKey'}, |
177 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
178 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
179 | + 'key': ('django.db.models.fields.TextField', [], {}), |
180 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}), |
181 | + 'user': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['auth.User']"}) |
182 | + }, |
183 | + u'maasserver.tag': { |
184 | + 'Meta': {'object_name': 'Tag'}, |
185 | + 'comment': ('django.db.models.fields.TextField', [], {'blank': 'True'}), |
186 | + 'created': ('django.db.models.fields.DateTimeField', [], {}), |
187 | + 'definition': ('django.db.models.fields.TextField', [], {'blank': 'True'}), |
188 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
189 | + 'kernel_opts': ('django.db.models.fields.TextField', [], {'null': 'True', 'blank': 'True'}), |
190 | + 'name': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '256'}), |
191 | + 'updated': ('django.db.models.fields.DateTimeField', [], {}) |
192 | + }, |
193 | + u'maasserver.userprofile': { |
194 | + 'Meta': {'object_name': 'UserProfile'}, |
195 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
196 | + 'user': ('django.db.models.fields.related.OneToOneField', [], {'to': u"orm['auth.User']", 'unique': 'True'}) |
197 | + }, |
198 | + u'piston.consumer': { |
199 | + 'Meta': {'object_name': 'Consumer'}, |
200 | + 'description': ('django.db.models.fields.TextField', [], {}), |
201 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
202 | + 'key': ('django.db.models.fields.CharField', [], {'max_length': '18'}), |
203 | + 'name': ('django.db.models.fields.CharField', [], {'max_length': '255'}), |
204 | + 'secret': ('django.db.models.fields.CharField', [], {'max_length': '32'}), |
205 | + 'status': ('django.db.models.fields.CharField', [], {'default': "'pending'", 'max_length': '16'}), |
206 | + 'user': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'consumers'", 'null': 'True', 'to': u"orm['auth.User']"}) |
207 | + }, |
208 | + u'piston.token': { |
209 | + 'Meta': {'object_name': 'Token'}, |
210 | + 'callback': ('django.db.models.fields.CharField', [], {'max_length': '255', 'null': 'True', 'blank': 'True'}), |
211 | + 'callback_confirmed': ('django.db.models.fields.BooleanField', [], {'default': 'False'}), |
212 | + 'consumer': ('django.db.models.fields.related.ForeignKey', [], {'to': u"orm['piston.Consumer']"}), |
213 | + u'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}), |
214 | + 'is_approved': ('django.db.models.fields.BooleanField', [], {'default': 'False'}), |
215 | + 'key': ('django.db.models.fields.CharField', [], {'max_length': '18'}), |
216 | + 'secret': ('django.db.models.fields.CharField', [], {'max_length': '32'}), |
217 | + 'timestamp': ('django.db.models.fields.IntegerField', [], {'default': '1381837275L'}), |
218 | + 'token_type': ('django.db.models.fields.IntegerField', [], {}), |
219 | + 'user': ('django.db.models.fields.related.ForeignKey', [], {'blank': 'True', 'related_name': "'tokens'", 'null': 'True', 'to': u"orm['auth.User']"}), |
220 | + 'verifier': ('django.db.models.fields.CharField', [], {'max_length': '10'}) |
221 | + } |
222 | + } |
223 | + |
224 | + complete_apps = ['maasserver'] |
225 | \ No newline at end of file |
226 | |
227 | === modified file 'src/maasserver/models/node.py' |
228 | --- src/maasserver/models/node.py 2013-10-15 07:40:29 +0000 |
229 | +++ src/maasserver/models/node.py 2013-10-15 11:42:28 +0000 |
230 | @@ -435,6 +435,8 @@ |
231 | |
232 | routers = djorm_pgarray.fields.ArrayField(dbtype="macaddr") |
233 | |
234 | + agent_name = CharField(max_length=255, default='', blank=True, null=True) |
235 | + |
236 | # Juju expects the following standard constraints, which are stored here |
237 | # as a basic optimisation over querying the lshw output. |
238 | cpu_count = IntegerField(default=0) |
I can see, by running `make syncdb`, that agent_name cannot be null, but can you make that explicit in the code with a null=False?