Merge lp:~rvb/maas-test/vm-series into lp:maas-test

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 88
Merged at revision: 89
Proposed branch: lp:~rvb/maas-test/vm-series
Merge into: lp:maas-test
Diff against target: 74 lines (+22/-2)
4 files modified
docs/man/maas-test.8.rst (+5/-0)
maastest/cases.py (+1/-1)
maastest/parser.py (+11/-1)
man/maas-test.8 (+5/-0)
To merge this branch: bzr merge lp:~rvb/maas-test/vm-series
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+198092@code.launchpad.net

Commit message

Add parameter to specify using a particular series for the VM.

To post a comment you must log in.
lp:~rvb/maas-test/vm-series updated
86. By Raphaël Badin

Fix default param.

87. By Raphaël Badin

Generate man.

Revision history for this message
Gavin Panella (allenap) wrote :

"--vm-series" implies some knowledge of maas-test's internals. How about "--controller-series" or "--maas-series" or something better?

review: Approve
Revision history for this message
Raphaël Badin (rvb) wrote :

> "--vm-series" implies some knowledge of maas-test's internals. How about
> "--controller-series" or "--maas-series" or something better?

Hum, that's a good point. "--maas-series" sounds good.

lp:~rvb/maas-test/vm-series updated
88. By Raphaël Badin

Rename option to --maas-series.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/man/maas-test.8.rst'
2--- docs/man/maas-test.8.rst 2013-12-06 12:44:22 +0000
3+++ docs/man/maas-test.8.rst 2013-12-09 16:30:28 +0000
4@@ -156,6 +156,11 @@
5 which defaults to `generic`, so e.g. `i386/generic` may be abbreviated to
6 `i386`. The default architecture is `amd64`.
7
8+--maas-series=codename
9+ Code name for the Ubuntu release series to install on the virtual
10+ machine (where the MAAS server will be installed). Defaults to the latest
11+ stable Ubuntu series.
12+
13 --http-proxy=URL
14 Use the given HTTP proxy for all downloads, both on the testing system and on
15 the nodes: KVM images, MAAS boot images, and Ubuntu packages. Like
16
17=== modified file 'maastest/cases.py'
18--- maastest/cases.py 2013-12-06 07:25:45 +0000
19+++ maastest/cases.py 2013-12-09 16:30:28 +0000
20@@ -83,7 +83,7 @@
21 proxy_url = proxy.get_url()
22
23 cls.machine = KVMFixture(
24- series='saucy', architecture=architecture,
25+ series=cls.args.vm_series, architecture=architecture,
26 proxy_url=proxy_url, direct_interface=cls.args.interface)
27 cls.fixtures.addCleanup(delattr, cls, "machine")
28 cls.fixtures.useFixture(cls.machine)
29
30=== modified file 'maastest/parser.py'
31--- maastest/parser.py 2013-12-06 07:47:07 +0000
32+++ maastest/parser.py 2013-12-09 16:30:28 +0000
33@@ -48,6 +48,7 @@
34
35
36 latest_LTS_series = distro_info.UbuntuDistroInfo().lts()
37+latest_released_series = distro_info.UbuntuDistroInfo().stable()
38
39
40 def prepare_parser():
41@@ -94,7 +95,16 @@
42 help="Password for authenticating to the node's BMC. "
43 "Not needed in interactive mode.")
44
45- # MAAS images.
46+ # VM details.
47+ parser.add_argument(
48+ '--maas-series', type=text_type,
49+ choices=utils.get_supported_series(),
50+ default=latest_released_series,
51+ help="Code name for the Ubuntu release series to install on the "
52+ "virtual machine (where the MAAS server will be installed). "
53+ "Defaults to the latest stable Ubuntu series (%(default)s).")
54+
55+ # MAAS images.
56 parser.add_argument(
57 '--series', type=text_type,
58 choices=utils.get_supported_series(),
59
60=== modified file 'man/maas-test.8'
61--- man/maas-test.8 2013-12-06 12:44:22 +0000
62+++ man/maas-test.8 2013-12-09 16:30:28 +0000
63@@ -170,6 +170,11 @@
64 which defaults to \fIgeneric\fP, so e.g. \fIi386/generic\fP may be abbreviated to
65 \fIi386\fP\&. The default architecture is \fIamd64\fP\&.
66 .TP
67+.BI \-\-maas\-series\fB= codename
68+Code name for the Ubuntu release series to install on the virtual
69+machine (where the MAAS server will be installed). Defaults to the latest
70+stable Ubuntu series.
71+.TP
72 .BI \-\-http\-proxy\fB= URL
73 Use the given HTTP proxy for all downloads, both on the testing system and on
74 the nodes: KVM images, MAAS boot images, and Ubuntu packages. Like

Subscribers

People subscribed via source and target branches