Merge lp:~rvb/maas-test/better-create into lp:maas-test

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 79
Merged at revision: 81
Proposed branch: lp:~rvb/maas-test/better-create
Merge into: lp:maas-test
Prerequisite: lp:~rvb/maas-test/warn-not-block
Diff against target: 25 lines (+4/-0)
2 files modified
maastest/kvmfixture.py (+3/-0)
maastest/tests/test_kvmfixture.py (+1/-0)
To merge this branch: bzr merge lp:~rvb/maas-test/better-create
Reviewer Review Type Date Requested Status
Graham Binns (community) Approve
Review via email: mp+197196@code.launchpad.net

Commit message

Add options to improve the performance of the VM.

Description of the change

--unsafe-caching improves significantly the performance of the VM, especially when running on a KVM machine. It's safe to use that for us, especially since our instances are short-lived, disposable machines.
--disk 20 (the default is 8) is just to make sure we have enough room. The disk is not pre-allocated so there is no cost in doing that.
--memory 2048, well, this also significantly improves the performance of the VM

To post a comment you must log in.
Revision history for this message
Graham Binns (gmb) wrote :

a

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'maastest/kvmfixture.py'
2--- maastest/kvmfixture.py 2013-11-28 14:14:59 +0000
3+++ maastest/kvmfixture.py 2013-11-29 13:16:48 +0000
4@@ -258,6 +258,9 @@
5 run_command([
6 "sudo", "uvt-kvm", "create",
7 "--ssh-public-key-file=%s" % self.get_ssh_public_key_file(),
8+ "--unsafe-caching",
9+ "--memory", "2048",
10+ "--disk", "20",
11 self.name,
12 "arch=%s" % self.architecture,
13 "release=%s" % self.series, "--template", "-"],
14
15=== modified file 'maastest/tests/test_kvmfixture.py'
16--- maastest/tests/test_kvmfixture.py 2013-11-28 14:15:34 +0000
17+++ maastest/tests/test_kvmfixture.py 2013-11-29 13:16:48 +0000
18@@ -258,6 +258,7 @@
19 mock.call([
20 'sudo', 'uvt-kvm', 'create',
21 '--ssh-public-key-file=%s' % public_key,
22+ '--unsafe-caching', '--memory', '2048', '--disk', '20',
23 name,
24 'arch=%s' % architecture, 'release=%s' % series,
25 '--template', '-'],

Subscribers

People subscribed via source and target branches