maas-test

Merge lp:~rvb/maas-test/add-virtualenv into lp:maas-test

  1. add-virtualenv
  2. Merge into trunk
Proposed by Raphaël Badin
Status: Merged
Merged at revision: 60
Proposed branch: lp:~rvb/maas-test/add-virtualenv
Merge into: lp:maas-test
Diff against target: 13 lines (+3/-0)
1 file modified
packages.txt (+3/-0)
To merge this branch: bzr merge lp:~rvb/maas-test/add-virtualenv
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+196524@code.launchpad.net

Commit message

Add python-virtualenv to packages.txt.

Description of the change

python-virtualenv is not a production dependency per-se, but it's required to create the dev/test environment so it's a bit of a chicken and egg problem. I figured it was simpler to put it packages.txt with a comment.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fair enough. And I don't suppose we'd want to spend the time downloading it every time — compared to just having it installed on the system.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'packages.txt'
2--- packages.txt 2013-11-19 15:22:08 +0000
3+++ packages.txt 2013-11-25 11:35:40 +0000
4@@ -8,6 +8,9 @@
5 python-six
6 python-testresources
7 python-testtools
8+# python-virtualenv is not a production dependency but it's required to create
9+# the dev/test environment.
10+python-virtualenv
11 python3-fixtures
12 python3-lxml
13 python3-mock

Subscribers

People subscribed via source and target branches