Code review comment for lp:~rvb/launchpad/sync-bug-827608-credit-copy

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> This branch looks good. I'm a little concerned about the change in sort order
> from getLatestMaintainedPackages as that change will be visible on the browser
> pages. Hope it isn't jarring.

Thanks a lot for the review. I checked this with Julian and also had a few queries run on the production db to have an idea of the impact of this reordering. I think this really makes sense (the spph.datecreated is more accurate for what we want to show) and also the impact will be pretty minimal from what I can see looking at production data.

« Back to merge proposal