Merge lp:~rvb/launchpad/deriv-ui-fixes into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Raphaël Badin |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12928 |
Proposed branch: | lp:~rvb/launchpad/deriv-ui-fixes |
Merge into: | lp:launchpad |
Diff against target: |
130 lines (+28/-18) 5 files modified
lib/lp/registry/browser/tests/test_distroseries.py (+4/-4) lib/lp/registry/javascript/tests/test_distroseries.js (+1/-1) lib/lp/registry/templates/distroseries-initialize.pt (+4/-0) lib/lp/registry/templates/distroseries-portlet-derivation.pt (+18/-12) lib/lp/registry/templates/distroseriesdifference-listing-extra.pt (+1/-1) |
To merge this branch: | bzr merge lp:~rvb/launchpad/deriv-ui-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+58793@code.launchpad.net |
Commit message
[r=gmb][bug=747392] Fix a few minor UI glitches in the UI for derived series.
Description of the change
This branch fixes a few minor glitches in the derived series' UI.
= Test =
(modified test)
./bin/test -cvv test_distroseries test_difference
= List of fixes/QA =
- On a difference page, the comments section's header should be <strong> (and not <h2>)
https:/
- The derivation portlet on a derived series home page should say "2772 packages *only* in Sid." instead of "2772 packages in Sid."
https:/
- The links inside the derivation portlet on a derived series should have a title, and the icon next to the text should be clickable.
- The initseries page should have a message at the bottom of the page saying "Note that initializing with many thousands of packages is likely to take hours to complete.".
https:/
- The submit button of the initseries page should say "Commence initialization". The title of this page should say "Initialize series" (as opposed to "Initialise series")
https:/
Hi Raphaël,
Only one minor change suggested, as discussed on IRC:
<gmb> rvba: I know that bigjools suggested it in the bug, but I think "Commence Initialization" isn't a good choice of wording for the button. It sounds pretty formal (and a bit silly). It would make more sense to have the help text read something like:
<gmb> "Note that initialization is not instantaneous; initializing with many thousands of packages is likely to take hours to complete."
<gmb> And leave the button as it is already.
<gmb> rvba: How's that sound?
<rvba> gmb: sound good to me!