Code review comment for lp:~rvb/launchpad/confirmationoverlay-button-optional

Graham Binns (gmb) wrote :

Hi Raphaël,

Nice branch; I've only got one minor tweak for you to make before this lands:

[1]

48 + if (button !== null) {

Since we're in a YUI environment, you should use if(Y.Lang.isValue(button)) here rather than checking for !== null.

review: Approve (code)

« Back to merge proposal