Merge lp:~rvb/gwacl/testing-utility into lp:gwacl

[Raphaël Badin]

Add testing utility.

This utility is there to let libraries using gwacl (for instance the Azure provider in juju-core) create testing StorageContext objects.

[Gavin Panella (allenap)]

[1]

+func CreateTestStorageContext(client *http.Client) *StorageContext {

The prefix is usually "New" in Go instead of "Create". I'm not bothered either way, as long as it's consistent with what's there already, or, failing that, consistent with Go convention.

review: Approve

[lp:~rvb/gwacl/testing-utility]

112. By Raphaël Badin on 2013-06-18

Review fixes.

[Raphaël Badin (rvb)]

> [1]
>
> +func CreateTestStorageContext(client *http.Client) *StorageContext {
>
> The prefix is usually "New" in Go instead of "Create". I'm not bothered either
> way, as long as it's consistent with what's there already, or, failing that,
> consistent with Go convention.

Good point, fixed.

[Julian Edwards (julian-edwards)]

On 18/06/13 23:43, Raphaël Badin wrote:
>
> === added file 'testing.go'

This needs to be of the form XXXXX_test.go, because otherwise it's going
to get compiled into a final build instead of being restricted to test code.

=== added file 'testing.go'
--- testing.go	1970-01-01 00:00:00 +0000
+++ testing.go	2013-06-18 13:53:26 +0000
@@ -0,0 +1,18 @@
+// Copyright 2013 Canonical Ltd.  This software is licensed under the
+// GNU Lesser General Public License version 3 (see the file COPYING).
+
+package gwacl
+
+import (
+    "net/http"
+)
+
+// NewTestStorageContext returns a StorageContext object built using
+// the given *http.Client object.  It's meant to be used in the tests
+// of other libraries using gwacl to create a StorageContext that will
+// interact with a fake client object.
+func NewTestStorageContext(client *http.Client) *StorageContext {
+    storageContext := &StorageContext{}
+    storageContext.client = client
+    return storageContext
+}

=== added file 'testing_test.go'
--- testing_test.go	1970-01-01 00:00:00 +0000
+++ testing_test.go	2013-06-18 13:53:26 +0000
@@ -0,0 +1,25 @@
+// Copyright 2013 Canonical Ltd.  This software is licensed under the
+// GNU Lesser General Public License version 3 (see the file COPYING).
+
+package gwacl
+
+import (
+    "fmt"
+    . "launchpad.net/gocheck"
+    "net/http"
+)
+
+type testTesting struct{}
+
+var _ = Suite(&testTesting{})
+
+func (suite *testTesting) TestNewTestStorageContext(c *C) {
+    errorMessage := "canned-error"
+    error := fmt.Errorf(errorMessage)
+    transport := &TestTransport{Error: error}
+    client := &http.Client{Transport: transport}
+    context := NewTestStorageContext(client)
+    request := &ListContainersRequest{Marker: ""}
+    _, err := context.ListContainers(request)
+    c.Check(err, ErrorMatches, ".*"+errorMessage+".*")
+}