Merge lp:~rvb/gwacl/fix-conflict into lp:gwacl

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 156
Merged at revision: 156
Proposed branch: lp:~rvb/gwacl/fix-conflict
Merge into: lp:gwacl
Diff against target: 49 lines (+14/-13)
2 files modified
xmlobjects.go (+11/-11)
xmlobjects_test.go (+3/-2)
To merge this branch: bzr merge lp:~rvb/gwacl/fix-conflict
Reviewer Review Type Date Requested Status
Gavin Panella Approve
Review via email: mp+172600@code.launchpad.net

Commit message

Fix semantic conflict between Julian's branch and mine. (NetworkConfiguration is not an object anymore, it's just a ConfigurationSet object with a 'NetworkConfiguration' type.)

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'xmlobjects.go'
2--- xmlobjects.go 2013-07-02 14:21:28 +0000
3+++ xmlobjects.go 2013-07-02 15:40:33 +0000
4@@ -496,17 +496,17 @@
5 // GetRole response bits
6 //
7 type GetRole struct {
8- XMLName xml.Name `xml:"PersistentVMRole"`
9- XMLNS string `xml:"xmlns,attr"`
10- XMLNS_I string `xml:"xmlns:i,attr"`
11- RoleName string `xml:"RoleName"`
12- OsVersion string `xml:"OsVersion"`
13- RoleType string `xml:"RoleType"` // Always PersistentVMRole
14- ConfigurationSets []NetworkConfiguration `xml:"ConfigurationSets>ConfigurationSet"`
15- AvailabilitySetName string `xml:"AvailabilitySetName"`
16- OSVirtualHardDisk OSVirtualHardDisk `xml:"OSVirtualHardDisk"`
17- RoleSize string `xml:"RoleSize"`
18- DefaultWinRmCertificateThumbprint string `xml:"DefaultWinRmCertificateThumbprint"`
19+ XMLName xml.Name `xml:"PersistentVMRole"`
20+ XMLNS string `xml:"xmlns,attr"`
21+ XMLNS_I string `xml:"xmlns:i,attr"`
22+ RoleName string `xml:"RoleName"`
23+ OsVersion string `xml:"OsVersion"`
24+ RoleType string `xml:"RoleType"` // Always PersistentVMRole
25+ ConfigurationSets []ConfigurationSet `xml:"ConfigurationSets>ConfigurationSet"`
26+ AvailabilitySetName string `xml:"AvailabilitySetName"`
27+ OSVirtualHardDisk OSVirtualHardDisk `xml:"OSVirtualHardDisk"`
28+ RoleSize string `xml:"RoleSize"`
29+ DefaultWinRmCertificateThumbprint string `xml:"DefaultWinRmCertificateThumbprint"`
30 // TODO: DataVirtualHardDisks and other info we don't need right now
31 }
32
33
34=== modified file 'xmlobjects_test.go'
35--- xmlobjects_test.go 2013-07-02 14:21:28 +0000
36+++ xmlobjects_test.go 2013-07-02 15:40:33 +0000
37@@ -149,9 +149,10 @@
38 RoleName: "name-of-the-vm",
39 OsVersion: "operating-system-version",
40 RoleType: "PersistentVMRole",
41- ConfigurationSets: []NetworkConfiguration{
42+ ConfigurationSets: []ConfigurationSet{
43 {
44- InputEndpoints: []InputEndpoint{
45+ ConfigurationSetType: "NetworkConfiguration",
46+ InputEndpoints: &[]InputEndpoint{
47 {
48 LoadBalancedEndpointSetName: "name-of-load-balanced-endpoint-set",
49 LocalPort: 1,

Subscribers

People subscribed via source and target branches

to all changes: