Merge lp:~rvb/gwacl/check-err into lp:gwacl

Proposed by Raphaël Badin
Status: Merged
Approved by: Raphaël Badin
Approved revision: 190
Merged at revision: 191
Proposed branch: lp:~rvb/gwacl/check-err
Merge into: lp:gwacl
Diff against target: 35 lines (+7/-6)
2 files modified
example/management/run.go (+2/-1)
xmlobjects.go (+5/-5)
To merge this branch: bzr merge lp:~rvb/gwacl/check-err
Reviewer Review Type Date Requested Status
Julian Edwards (community) Approve
Review via email: mp+175469@code.launchpad.net

Commit message

Add check for error in example script.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review: approve

I have the same formatting fix in my branch.... I bet I get a conflict
now!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlHnt88ACgkQWhGlTF8G/HfpKwCeNTAfZAzoExU6VKgbAGStXn2n
IPoAn3ETCUAWIwi/4fH5wAt6NOfvEfR7
=Os87
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'example/management/run.go'
2--- example/management/run.go 2013-07-17 12:14:33 +0000
3+++ example/management/run.go 2013-07-18 08:20:36 +0000
4@@ -101,8 +101,9 @@
5
6 defer func() {
7 fmt.Printf("Deleting affinity group %s\n", affinityGroupName)
8- api.DeleteAffinityGroup(&gwacl.DeleteAffinityGroupRequest{
9+ err := api.DeleteAffinityGroup(&gwacl.DeleteAffinityGroupRequest{
10 Name: affinityGroupName})
11+ checkError(err)
12 fmt.Printf("Done deleting affinity group %s\n", affinityGroupName)
13 }()
14
15
16=== modified file 'xmlobjects.go'
17--- xmlobjects.go 2013-07-18 01:45:02 +0000
18+++ xmlobjects.go 2013-07-18 08:20:36 +0000
19@@ -80,11 +80,11 @@
20 Hostname, Username, Password, CustomData string,
21 DisableSSHPasswordAuthentication string) *ConfigurationSet {
22 return &ConfigurationSet{
23- ConfigurationSetType: "LinuxProvisioningConfiguration",
24- Hostname: Hostname,
25- Username: Username,
26- Password: Password,
27- CustomData: CustomData,
28+ ConfigurationSetType: "LinuxProvisioningConfiguration",
29+ Hostname: Hostname,
30+ Username: Username,
31+ Password: Password,
32+ CustomData: CustomData,
33 DisableSSHPasswordAuthentication: DisableSSHPasswordAuthentication,
34 }
35 }

Subscribers

People subscribed via source and target branches

to all changes: