Merge ~ruinedyourlife/launchpad:feat-update-gitignore into launchpad:master

Proposed by Quentin Debhi
Status: Needs review
Proposed branch: ~ruinedyourlife/launchpad:feat-update-gitignore
Merge into: launchpad:master
Diff against target: 164 lines (+81/-54)
1 file modified
.gitignore (+81/-54)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+465565@code.launchpad.net

Commit message

Ignore vscode files and tidying up

Adding `launch.json` to `.gitignore` for vscode users, which allows for tests configuration in the first place. Also tidy up what's already existing.

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) wrote :

I like the new organization style and the clusters seem relevant. Just a minor comment about the "build artifacts" title.

I also quickly checked that the same 78 lines are there in the rework as a small sanity check :P

review: Approve

Unmerged commits

f62db5e... by Quentin Debhi

feat: ignore vscode cfg

Succeeded
[SUCCEEDED] docs:0 (build)
[SUCCEEDED] lint:0 (build)
[SUCCEEDED] mypy:0 (build)
13 of 3 results
58cf911... by Quentin Debhi

feat: organize gitignore

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.gitignore b/.gitignore
2index 82f290a..dfef53c 100644
3--- a/.gitignore
4+++ b/.gitignore
5@@ -1,37 +1,30 @@
6+# compiled python files
7 *.pyc
8+
9+# tags
10 .tags
11+/tags
12+TAGS
13+tags.new
14+
15+# version files
16 version-info.py
17 version-info.txt
18+
19+# log files
20 logs/*
21-+*
22-/botmaster
23-/tags
24-database/schema/diagrams/*.ps
25-database/schema/diagrams/*.dot
26-thread*.request
27-TAGS
28-cover.txt
29-.shelf
30-development-nohup.out
31-opensource/launchpadlib/build
32-opensource/launchpadlib/dist
33-opensource/launchpadlib/*.egg*
34-database/sampledata/newsampledata.sql
35-database/sampledata/newsampledata-dev.sql
36-database/sampledata/lintdata.sql
37-database/sampledata/lintdata-dev.sql
38-lib/canonical/launchpad/apidoc/*.html
39-xxx-report.*
40-lib/canonical/launchpad/apidoc/wadl-development-*.xml
41-lib/canonical/launchpad/apidoc/wadl-test-playground.xml
42-lib/canonical/launchpad/icing/build/*
43-lib/canonical/launchpad/icing/base.css
44-lib/canonical/launchpad/icing/base.css.map
45-lib/canonical/launchpad/icing/combo.css
46-lib/canonical/launchpad/icing/combo.css.map
47-bin
48-.installed.cfg
49-parts
50+!logs/README.txt
51+/logs
52+librarian.log
53+
54+# development tools configurations
55+.project
56+.pydevproject
57+.idea
58+.emacs.desktop
59+.vscode
60+
61+# build artifacts
62 *.egg-info
63 build
64 dist
65@@ -39,40 +32,74 @@ dist
66 /download-cache
67 /env
68 /production-configs
69-bzr.dev
70-_trial_temp
71-.bazaar
72+bin
73+.installed.cfg
74+parts
75+
76+# specific software or tools
77+.tox/
78+/geckodriver.log
79 .cache
80 .subversion
81 .testrepository
82+.bazaar
83 .memcache.pid
84-lib/canonical/launchpad/apidoc/wadl-development-*.xml
85-tags.new
86-lp-clustered.dot
87-lp-clustered.sfood
88-lp-clustered.svg
89-lp.sfood
90-apidocs
91 twistd.pid
92+_trial_temp
93+/celerybeat-schedule
94+requirements/combined.txt
95+
96+# revision control systems
97+bzr.dev
98+
99+# launchpad specific
100 lib/canonical/launchpad/apidoc
101-*.prof
102-.project
103-.pydevproject
104-librarian.log
105-configs/testrunner_*
106-configs/testrunner-appserver_*
107-.idea
108-run.gdb
109+lib/canonical/launchpad/apidoc/*.html
110+lib/canonical/launchpad/apidoc/wadl-development-*.xml
111+lib/canonical/launchpad/apidoc/wadl-test-playground.xml
112+lib/canonical/launchpad/icing/build/*
113+lib/canonical/launchpad/icing/base.css
114+lib/canonical/launchpad/icing/base.css.map
115+lib/canonical/launchpad/icing/combo.css
116+lib/canonical/launchpad/icing/combo.css.map
117 lib/canonical/launchpad/icing/*-sprites-*.png
118 lib/canonical/launchpad/icing/*.positioning
119 lib/canonical/launchpad/icing/yui
120-.emacs.desktop
121+
122+# database schemas and sample data
123+database/schema/diagrams/*.ps
124+database/schema/diagrams/*.dot
125+database/sampledata/newsampledata.sql
126+database/sampledata/newsampledata-dev.sql
127+database/sampledata/lintdata.sql
128+database/sampledata/lintdata-dev.sql
129+
130+# source and development files
131+thread*.request
132+cover.txt
133+.shelf
134+development-nohup.out
135+opensource/launchpadlib/build
136+opensource/launchpadlib/dist
137+opensource/launchpadlib/*.egg*
138+
139+# profiling and debugging
140+*.prof
141 callgrind.out.*
142-/celerybeat-schedule
143-!logs/README.txt
144-/logs
145+run.gdb
146+
147+# node and python packages
148 yarn/node_modules
149 /wheels
150-requirements/combined.txt
151-.tox/
152-/geckodriver.log
153+
154+# misc
155++*
156+/botmaster
157+xxx-report.*
158+lp-clustered.dot
159+lp-clustered.sfood
160+lp-clustered.svg
161+lp.sfood
162+apidocs
163+configs/testrunner_*
164+configs/testrunner-appserver_*

Subscribers

People subscribed via source and target branches

to status/vote changes: