Merge lp:~ruchir.shukla/banking-addons/banking-addons-supplier-invoice-number into lp:banking-addons

[Ruchir Shukla(BizzAppDev)]

Provide a facility for Matching Supplier Invoice based on supplier invoice number provided in invoice in supplier_invoice_number field.

[Pedro Manuel Baeza (pedro.baeza)]

LGTM

review: Approve (code review, no test)

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks. Please add a check on the length of the value to be larger than 2 like is done on other field values, to prevent a large number of false positives.

review: Needs Fixing

[lp:~ruchir.shukla/banking-addons/banking-addons-supplier-invoice-number]

185. By Ruchir Shukla(BizzAppDev) on 2013-08-24

add condition for grater than 2 len

[Ruchir Shukla(BizzAppDev) (ruchir.shukla)]

> Thanks. Please add a check on the length of the value to be larger than 2
> like is done on other field values, to prevent a large number of false
> positives.
Changes are done as requested .

review: Needs Resubmitting

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks!

review: Approve

=== modified file 'account_banking/banking_import_transaction.py'
--- account_banking/banking_import_transaction.py	2013-08-12 09:20:35 +0000
+++ account_banking/banking_import_transaction.py	2013-08-24 11:00:40 +0000
@@ -193,6 +193,10 @@
                     iname = invoice.name.upper()
                     if iname in ref or iname in msg:
                         return True
+                if invoice.supplier_invoice_number and len(invoice.supplier_invoice_number) > 2:
+                    supp_ref = invoice.supplier_invoice_number.upper()
+                    if supp_ref in ref or supp_ref in msg:
+                        return True
             elif invoice.type.startswith('out_'):
                 # External id's possible and likely
                 inum = invoice.number.upper()