Merge lp:~ruchir.shukla/banking-addons/banking-addons-payment-order-improvment into lp:banking-addons

Proposed by Ruchir Shukla(BizzAppDev)
Status: Merged
Approved by: Guewen Baconnier @ Camptocamp
Approved revision: 209
Merged at revision: 222
Proposed branch: lp:~ruchir.shukla/banking-addons/banking-addons-payment-order-improvment
Merge into: lp:banking-addons
Diff against target: 27 lines (+9/-2)
2 files modified
account_banking_payment/model/payment_order_create.py (+8/-1)
account_payment_shortcut/__openerp__.py (+1/-1)
To merge this branch: bzr merge lp:~ruchir.shukla/banking-addons/banking-addons-payment-order-improvment
Reviewer Review Type Date Requested Status
Guewen Baconnier @ Camptocamp Approve
Holger Brunn (Therp) code review Approve
Review via email: mp+198501@code.launchpad.net

Description of the change

return Form view of Payment Orders so record will be reloaded
make account_payment_shortcut installable so default Invoices will be selected in Wizard

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) :
review: Approve
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Ruchir,

sorry I missed this one. Please check if the code needs updating when you activate a module! In this case, it is thankfully only a very small number of changes. Additionally, I think reloading the payment order view is a workaround for https://bugs.launchpad.net/openerp-web/+bug/1155525 so this had better be pointed out in a comment. You can find these small changes here: https://code.launchpad.net/~therp-nl/banking-addons/ba70-fix_payment_order_improvements/+merge/204485.

Could you review my additional changes to this proposal?

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_payment/model/payment_order_create.py'
2--- account_banking_payment/model/payment_order_create.py 2013-09-12 07:05:59 +0000
3+++ account_banking_payment/model/payment_order_create.py 2013-12-11 06:44:15 +0000
4@@ -194,4 +194,11 @@
5 or line.journal_id.currency.id
6 or line.journal_id.company_id.currency_id.id),
7 }, context=context)
8- return {'type': 'ir.actions.act_window_close'}
9+ return {'name': _('Payment Orders'),
10+ 'context': context,
11+ 'view_type': 'form',
12+ 'view_mode': 'form,tree',
13+ 'res_model': 'payment.order',
14+ 'res_id': context['active_id'],
15+ 'type': 'ir.actions.act_window',
16+ }
17
18=== modified file 'account_payment_shortcut/__openerp__.py'
19--- account_payment_shortcut/__openerp__.py 2013-04-15 14:14:27 +0000
20+++ account_payment_shortcut/__openerp__.py 2013-12-11 06:44:15 +0000
21@@ -29,5 +29,5 @@
22 'description': '''
23 When composing a payment order, select all candidates by default (in the second step of the "Select invoices to pay" wizard).
24 ''',
25- 'installable': False,
26+ 'installable': True,
27 }

Subscribers

People subscribed via source and target branches

to status/vote changes: