Banking Addons

Merge lp:~ruchir.shukla/banking-addons/banking-addons-fix-1334526 into lp:banking-addons

  1. banking-addons-fix-1334526
  2. Merge into banking-addons-70
Proposed by Ruchir Shukla(BizzAppDev)
Status: Needs review
Proposed branch: lp:~ruchir.shukla/banking-addons/banking-addons-fix-1334526
Merge into: lp:banking-addons
Diff against target: 12 lines (+2/-0)
1 file modified
account_banking_pain_base/banking_export_pain.py (+2/-0)
To merge this branch: bzr merge lp:~ruchir.shukla/banking-addons/banking-addons-fix-1334526
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Review via email: mp+224554@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Strange case, but can be.

LGTM.

Regards.

review: Approve (code review)
Reply
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

We moved to https://github.com/OCA/banking. Please create a git pull request there.

Reply

Unmerged revisions

263. By Ruchir Shukla(BizzAppDev)

initialize nb_of_transactions_2_4 and control_sum_2_5 with Default value

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_banking_pain_base/banking_export_pain.py'
2--- account_banking_pain_base/banking_export_pain.py 2014-02-16 13:55:30 +0000
3+++ account_banking_pain_base/banking_export_pain.py 2014-06-26 06:44:42 +0000
4@@ -210,6 +210,8 @@
5 gen_args=gen_args, context=context)
6 payment_method_2_2 = etree.SubElement(payment_info_2_0, 'PmtMtd')
7 payment_method_2_2.text = gen_args['payment_method']
8+ nb_of_transactions_2_4 = False
9+ control_sum_2_5 = False
10 if gen_args.get('pain_flavor') != 'pain.001.001.02':
11 batch_booking_2_3 = etree.SubElement(payment_info_2_0, 'BtchBookg')
12 batch_booking_2_3.text = \

Subscribers

People subscribed via source and target branches

to status/vote changes: