Merge lp:~ruchir.shukla/banking-addons/banking-addons-fix-1266890 into lp:banking-addons

[Ruchir Shukla(BizzAppDev)]

Fix bug

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks! I'm thinking that the account should be readonly if there is any match type at all, not just move or payment. Do you agree?

review: Needs Information

[lp:~ruchir.shukla/banking-addons/banking-addons-fix-1266890]

220. By Ruchir Shukla(BizzAppDev) on 2014-01-27

fix the condition

[Ruchir Shukla(BizzAppDev) (ruchir.shukla)]

Hello Stefan !
Thank you for review and raise that point. I have make changes for any match type it will be readonly.

[lp:~ruchir.shukla/banking-addons/banking-addons-fix-1266890]

221. By Ruchir Shukla(BizzAppDev) on 2014-01-27

fix condition

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for the change!

review: Approve

=== modified file 'account_banking/account_banking_view.xml'
--- account_banking/account_banking_view.xml	2013-10-31 07:33:46 +0000
+++ account_banking/account_banking_view.xml	2014-01-27 08:49:39 +0000
@@ -95,7 +95,7 @@
             action="action_account_banking_journals"
             sequence="20"
          />
-        
+
         <!-- Create new view on imported statement files -->
         <record model="ir.ui.view" id="view_account_banking_imported_file_form">
             <field name="name">account.banking.imported.file.form</field>
@@ -221,7 +221,7 @@
                     </xpath>
 
                     <!-- Add invisible field for identification of import file
-                         on bank statements 
+                         on bank statements
                     -->
                     <field name="balance_end_real" position="after">
                         <field name="banking_id" invisible="True"/>
@@ -248,7 +248,10 @@
                            position="after">
                         <field name="partner_bank_id"/>
                     </xpath>
-
+                    <xpath expr="//field[@name='line_ids']/tree//field[@name='account_id']"
+                           position="attributes">
+                       <attribute name="attrs">{'readonly': ['|', ('state', '!=', 'draft'), ('match_type', '!=', '')]}</attribute>
+                    </xpath>
                     <xpath expr="//field[@name='line_ids']/tree/field[@name='amount']"
                            position="after">
                         <field name="match_type"/>
@@ -336,7 +339,8 @@
                     <field name="partner_bank_id"/>
                     <field name="type" on_change="onchange_type(partner_id, type)"/>
                     <!-- TODO note the references to parent from the statement form view -->
-                    <field domain="[('journal_id','=',parent.journal_id)]" name="account_id"/>
+                    <field domain="[('journal_id','=',parent.journal_id)]"
+                        attrs="{'readonly': ['|', ('state', '!=', 'draft'), ('match_type', '!=', '')]}" name="account_id"/>
                     <field name="analytic_account_id" groups="analytic.group_analytic_accounting" domain="[('company_id', '=', parent.company_id), ('type', '&lt;&gt;', 'view')]"/>
                     <field name="amount"/>
                     <field name="match_type"/>