Merge lp:~ruben-reina-dev/appcenter/fix_search_freezes into lp:~elementary-apps/appcenter/appcenter

[Rubén Reina]

* Search asynchronously
* Limit search results to 100 (for responsiveness)

After examining this bug, the changes I have applied are:
 - Ask the core (Client) for apps and add the apps to the UI in an asynchronous method.
 - Limit the number of displayed apps in a search result to 100. I have done this to improve the search responsiveness not overloading the UI too much.

[Danielle Foré (danrabbit)]

Does what it says on the tin :)

review: Approve

=== modified file 'src/MainWindow.vala'
--- src/MainWindow.vala	2016-06-29 01:20:31 +0000
+++ src/MainWindow.vala	2016-08-20 17:03:54 +0000
@@ -177,7 +177,7 @@
                     break;
             }
         } else {
-            search_view.search (research);
+            search_view.search.begin (research);
             if (!return_button.visible) {
                 view_mode_revealer.reveal_child = false;
                 stack.visible_child = search_view;

=== modified file 'src/Views/SearchView.vala'
--- src/Views/SearchView.vala	2015-12-10 19:53:13 +0000
+++ src/Views/SearchView.vala	2016-08-20 17:03:54 +0000
@@ -21,6 +21,7 @@
 using AppCenterCore;
 
 public class AppCenter.Views.SearchView : View {
+    const int MAX_NUMBER_OF_SEARCH_RESULTS = 100;
     AppListView app_list_view;
 
     public SearchView () {
@@ -40,13 +41,20 @@
     public override void return_clicked () {
         set_visible_child (app_list_view);
     }
-
-    public void search (string search_term) {
+    
+    public async void search (string search_term) {
+        app_list_view.clear ();
         unowned Client client = Client.get_default ();
         var found_apps = client.search_applications (search_term);
-        app_list_view.clear ();
-        foreach (var app in found_apps) {
-            app_list_view.add_package (app);
+        
+        if (found_apps.size > 0) {
+            var apps_array = found_apps.to_array ();
+            int i = 0;
+            while (i < apps_array.length && i < MAX_NUMBER_OF_SEARCH_RESULTS) {
+                var app = apps_array[i];
+                app_list_view.add_package (app);
+                i++;   
+            }
         }
     }
 }