Quick review things:
* make a better commit message (the 'Commit message` above will be be used when this is ultimately squashed and merged)
* add 'LP: #1841181' to your commit message. See git log for examples. Thats how MPs get associated with bugs.
* Tests needed.
* tests/unittests/test_ds_identify.py should be fairly to understand and update for Zstack
* Probably add a tests/unittests/test_datasource/test_zstack.py
* Add doc/rtd/topics/datasources/zstack.rst and update doc/rtd/topics/datasources.rst to reference it. See Exoscale for a recently added datasource example.
* Did you check to see if simply adding Zstack in the same way as BrightBox is added would work? That could be even less code.
Quick review things: /test_ds_ identify. py should be fairly to understand and update for Zstack /test_datasourc e/test_ zstack. py topics/ datasources/ zstack. rst and update doc/rtd/ topics/ datasources. rst to reference it. See Exoscale for a recently added datasource example.
* make a better commit message (the 'Commit message` above will be be used when this is ultimately squashed and merged)
* add 'LP: #1841181' to your commit message. See git log for examples. Thats how MPs get associated with bugs.
* Tests needed.
* tests/unittests
* Probably add a tests/unittests
* Add doc/rtd/
* Did you check to see if simply adding Zstack in the same way as BrightBox is added would work? That could be even less code.