Merge lp:~rsandifo/gcc-linaro/lp-710652-4.5 into lp:gcc-linaro/4.5

Proposed by Richard Sandiford
Status: Merged
Merged at revision: 99481
Proposed branch: lp:~rsandifo/gcc-linaro/lp-710652-4.5
Merge into: lp:gcc-linaro/4.5
Diff against target: 48 lines (+24/-1)
3 files modified
ChangeLog.linaro (+10/-0)
gcc/config/arm/predicates.md (+1/-1)
gcc/testsuite/gcc.target/arm/neon-vld-1.c (+13/-0)
To merge this branch: bzr merge lp:~rsandifo/gcc-linaro/lp-710652-4.5
Reviewer Review Type Date Requested Status
Andrew Stubbs (community) Approve
Review via email: mp+48316@code.launchpad.net

Description of the change

Posted upstream as:

http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02266.html

However, because the bug isn't a regression, the patch isn't
suitable for FSF 4.6 at this stage. There's also little real
chance of an upstream review until Richard gets back from
sabbatical.

To post a comment you must log in.
Revision history for this message
Andrew Stubbs (ams-codesourcery) wrote :

Applied and tested with no regressions. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2011-02-01 16:09:12 +0000
3+++ ChangeLog.linaro 2011-02-02 14:18:41 +0000
4@@ -1,3 +1,13 @@
5+2011-02-02 Richard Sandiford <richard.sandiford@linaro.org>
6+
7+
8+ gcc/testsuite/
9+ PR target/47553
10+ * gcc.target/arm/neon-vld-1.c: New test.
11+ gcc/
12+ PR target/47553
13+ * config/arm/predicates.md (neon_lane_number): Accept 0..15.
14+
15 2010-01-25 Tom de Vries <tom@codesourcery.com>
16
17 gcc/
18
19=== modified file 'gcc/config/arm/predicates.md'
20--- gcc/config/arm/predicates.md 2011-01-13 16:06:19 +0000
21+++ gcc/config/arm/predicates.md 2011-02-02 14:18:41 +0000
22@@ -563,7 +563,7 @@
23 ;; TODO: We could check lane numbers more precisely based on the mode.
24 (define_predicate "neon_lane_number"
25 (and (match_code "const_int")
26- (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 7")))
27+ (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 15")))
28 ;; Predicates for named expanders that overlap multiple ISAs.
29
30 (define_predicate "cmpdi_operand"
31
32=== added file 'gcc/testsuite/gcc.target/arm/neon-vld-1.c'
33--- gcc/testsuite/gcc.target/arm/neon-vld-1.c 1970-01-01 00:00:00 +0000
34+++ gcc/testsuite/gcc.target/arm/neon-vld-1.c 2011-02-02 14:18:41 +0000
35@@ -0,0 +1,13 @@
36+/* { dg-do compile } */
37+/* { dg-require-effective-target arm_neon_ok } */
38+/* { dg-options "-O1" } */
39+/* { dg-add-options arm_neon } */
40+
41+#include <arm_neon.h>
42+
43+uint8x16_t
44+foo (uint8_t *a, uint8x16_t b)
45+{
46+ vst1q_lane_u8 (a, b, 14);
47+ return vld1q_lane_u8 (a + 0x100, b, 15);
48+}

Subscribers

People subscribed via source and target branches