Merge lp:~rsalveti/webkit/arm-crash-fix into lp:~ubuntu-desktop/webkit/ubuntu

Proposed by Ricardo Salveti
Status: Merged
Merged at revision: 23
Proposed branch: lp:~rsalveti/webkit/arm-crash-fix
Merge into: lp:~ubuntu-desktop/webkit/ubuntu
Diff against target: 72 lines (+53/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/03_fixing_jit_arm_crashes.patch (+45/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~rsalveti/webkit/arm-crash-fix
Reviewer Review Type Date Requested Status
Jani Monoses Pending
Review via email: mp+52803@code.launchpad.net

Description of the change

Fix for bug 728211.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-02-28 18:26:04 +0000
3+++ debian/changelog 2011-03-10 06:24:15 +0000
4@@ -1,3 +1,10 @@
5+webkit (1.3.12-0ubuntu3) natty; urgency=low
6+
7+ * debian/patches/03_fixing_jit_arm_crashes.patch:
8+ - Fixing JIT ARM crashes (LP: #728211)
9+
10+ -- Ricardo Salveti de Araujo <ricardo.salveti@canonical.com> Wed, 09 Mar 2011 04:48:01 -0300
11+
12 webkit (1.3.12-0ubuntu2) natty; urgency=low
13
14 * Add bzr-builddeb configuration (merge mode).
15
16=== added file 'debian/patches/03_fixing_jit_arm_crashes.patch'
17--- debian/patches/03_fixing_jit_arm_crashes.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/03_fixing_jit_arm_crashes.patch 2011-03-10 06:24:15 +0000
19@@ -0,0 +1,45 @@
20+From 262cf5629343a565db417408cb9cb104baeefe21 Mon Sep 17 00:00:00 2001
21+From: xan@webkit.org <xan@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
22+Date: Wed, 23 Feb 2011 18:55:29 +0000
23+Subject: [PATCH] 2011-02-23 Xan Lopez <xlopez@igalia.com>
24+
25+ Reviewed by Gavin Barraclough.
26+
27+ latest jsc for armv7 crashes in sunspider tests
28+ https://bugs.webkit.org/show_bug.cgi?id=54667
29+
30+ Update JIT offset values in ARMv7 after r78732. Fixes crashes in
31+ SunSpider and JavaScript tests.
32+
33+ * jit/JIT.h: update values.
34+
35+git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
36+---
37+
38+diff --git a/Source/JavaScriptCore/jit/JIT.h b/Source/JavaScriptCore/jit/JIT.h
39+index 36d80af..0a7ad39 100644
40+--- a/Source/JavaScriptCore/jit/JIT.h
41++++ b/Source/JavaScriptCore/jit/JIT.h
42+@@ -402,14 +402,14 @@ namespace JSC {
43+ #elif CPU(ARM_THUMB2)
44+ // These architecture specific value are used to enable patching - see comment on op_put_by_id.
45+ static const int patchOffsetPutByIdStructure = 10;
46+- static const int patchOffsetPutByIdPropertyMapOffset1 = 46;
47+- static const int patchOffsetPutByIdPropertyMapOffset2 = 58;
48++ static const int patchOffsetPutByIdPropertyMapOffset1 = 36;
49++ static const int patchOffsetPutByIdPropertyMapOffset2 = 48;
50+ // These architecture specific value are used to enable patching - see comment on op_get_by_id.
51+ static const int patchOffsetGetByIdStructure = 10;
52+ static const int patchOffsetGetByIdBranchToSlowCase = 26;
53+- static const int patchOffsetGetByIdPropertyMapOffset1 = 46;
54+- static const int patchOffsetGetByIdPropertyMapOffset2 = 58;
55+- static const int patchOffsetGetByIdPutResult = 62;
56++ static const int patchOffsetGetByIdPropertyMapOffset1 = 36;
57++ static const int patchOffsetGetByIdPropertyMapOffset2 = 48;
58++ static const int patchOffsetGetByIdPutResult = 52;
59+ #if ENABLE(OPCODE_SAMPLING)
60+ #error "OPCODE_SAMPLING is not yet supported"
61+ #else
62+--
63+1.7.4.1
64+
65
66=== modified file 'debian/patches/series'
67--- debian/patches/series 2011-02-28 14:15:11 +0000
68+++ debian/patches/series 2011-03-10 06:24:15 +0000
69@@ -1,2 +1,3 @@
70 01_expose_less_symbols.patch
71 02_no_amd64_overcommit.patch
72+03_fixing_jit_arm_crashes.patch

Subscribers

People subscribed via source and target branches