Merge lp:~rsalveti/unity/phablet_adding_python_builddep into lp:unity/phablet

Proposed by Ricardo Salveti on 2013-03-12
Status: Merged
Approved by: Michael Zanetti on 2013-03-12
Approved revision: 454
Merged at revision: 454
Proposed branch: lp:~rsalveti/unity/phablet_adding_python_builddep
Merge into: lp:unity/phablet
Diff against target: 12 lines (+2/-1)
1 file modified
debian/control (+2/-1)
To merge this branch: bzr merge lp:~rsalveti/unity/phablet_adding_python_builddep
Reviewer Review Type Date Requested Status
Michael Zanetti (community) 2013-03-12 Approve on 2013-03-12
PS Jenkins bot (community) continuous-integration Approve on 2013-03-12
Review via email: mp+153013@code.launchpad.net

Commit message

debian/control: forcing build-dep at python2.7 as it's now a requirement from autopilot CMakeLists.txt

Description of the change

debian/control: forcing build-dep at python2.7 as it's now a requirement from autopilot CMakeLists.txt

To post a comment you must log in.
Ricardo Salveti (rsalveti) wrote :

The ideal solution (from the distro perspective) would be to make it depend on python 3, but for that the line at ./tests/autopilot/CMakeLists.txt would need to be fixed as well.

As I'm not sure if we'd have an issue with autopilot when using python 3, I just added the build-dep on python2.7 to allow the shell to build again at the PPA (doesn't fail at jenkins as pbuild installs python2.7 by default).

Michael Zanetti (mzanetti) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-03-08 14:43:08 +0000
3+++ debian/control 2013-03-12 20:59:26 +0000
4@@ -18,7 +18,8 @@
5 libunity-core-6.0-dev,
6 libpulse-dev,
7 libhud-client1-dev,
8- libdee-qt5-dev (>= 3.0)
9+ libdee-qt5-dev (>= 3.0),
10+ python2.7
11 Standards-Version: 3.9.3
12 Vcs-Bzr: lp:unity/phablet
13

Subscribers

People subscribed via source and target branches