Merge lp:~rsalveti/ubuntu/maverick/ureadahead/fix-600359 into lp:ubuntu/maverick/ureadahead

[Ricardo Salveti]

  * conf/ureadahead*.conf: only run ureadahead on systems with at least 512MB of ram. (LP: #600359)

Changing ureadahead initscript to avoid running ureadahead at systems with less than 512 MB of ram.

This is needed because ureadahead sets the tracing buffer to 128MB, and at a system with small amount of memory (Beagleboard) this can cause the boot to call the OOM, killing ureadahead and plymouthd.

Check bug 600359 for more details.

I decided to change only the initscript, instead of adding this restriction to the ureadahead code, because then the user can still run and test it if needed.

I also tried different memory thresholds, but didn't change the boot speed when comparing different bootcharts for BeagleBoard, so I just decided to avoid running it in this case.

[lp:~rsalveti/ubuntu/maverick/ureadahead/fix-600359]

11. By Tim Gardner on 2010-08-20

Count the number of CPUs and divide buffer_size_kb by the number of CPUs.
Users should watch for instances of "mmiotrace has lost events" in dmesg to make
sure the trace buffers are not too small. The original value for
buffer_size_kb was chosen somewhat arbitrarily. Empirical testing
has shown that its large enough, so we don't actually know where the lower
boundary lies.
-LP: #491943

12. By Ricardo Salveti on 2010-08-24

conf/ureadahead*.conf: only run ureadahead on systems with at least
512MB of ram. (LP: #600359)

[Evan Broder (broder)]

This merge proposal references a bug which appears to have been fixed through an alternative approach. Is this merge still needed? If it is needed, please rebase the patch on the current version of lp:ubuntu/ureadahead. If it is no longer needed, please let us know so that we can remove this proposal, or feel free to delete the proposal yourself.

review: Needs Information

[Dave Walker (davewalker)]

Rejecting, as Ricardo states it's no longer required.

review: Disapprove

Unmerged revisions

12. By Ricardo Salveti on 2010-08-24

conf/ureadahead*.conf: only run ureadahead on systems with at least
512MB of ram. (LP: #600359)

=== modified file 'conf/ureadahead-other.conf'
--- conf/ureadahead-other.conf	2009-12-21 23:20:02 +0000
+++ conf/ureadahead-other.conf	2010-08-24 05:14:39 +0000
@@ -16,4 +16,10 @@
 # don't treat a missing pack file as an error either
 normal exit 0 4
 
+pre-start script
+    # Just run on systems with at least ~512MB
+    MEM=$(grep ^MemTotal /proc/meminfo | awk -F' ' '{print $2}')
+    test $MEM -gt 500000 || { stop; exit 0; }
+end script
+
 exec /sbin/ureadahead --daemon $MOUNTPOINT

=== modified file 'conf/ureadahead.conf'
--- conf/ureadahead.conf	2009-11-09 18:38:51 +0000
+++ conf/ureadahead.conf	2010-08-24 05:14:39 +0000
@@ -20,6 +20,12 @@
 # Don't treat a normal exit after reading finishes as a failure
 normal exit 0
 
+pre-start script
+    # Just run on systems with at least ~512MB
+    MEM=$(grep ^MemTotal /proc/meminfo | awk -F' ' '{print $2}')
+    test $MEM -gt 500000 || { stop; exit 0; }
+end script
+
 exec /sbin/ureadahead --daemon
 
 # Normally ureadahead will exit on its own when it finishes, unless it's

=== modified file 'debian/changelog'
--- debian/changelog	2010-08-20 12:19:31 +0000
+++ debian/changelog	2010-08-24 05:14:39 +0000
@@ -1,3 +1,10 @@
+ureadahead (0.100.0-8) maverick; urgency=low
+
+  * conf/ureadahead*.conf: only run ureadahead on systems with at least
+    512MB of ram. (LP: #600359)
+
+ -- Ricardo Salveti de Araujo <[e-mail]>  Tue, 24 Aug 2010 02:11:23 -0300
+
 ureadahead (0.100.0-7) maverick; urgency=low
 
   * Count the number of CPUs and divide buffer_size_kb by the number of CPUs.