Merge lp:~rsalveti/ubuntu/maverick/ureadahead/fix-600359 into lp:ubuntu/maverick/ureadahead

Proposed by Ricardo Salveti on 2010-08-18
Status: Rejected
Rejected by: Dave Walker on 2010-12-03
Proposed branch: lp:~rsalveti/ubuntu/maverick/ureadahead/fix-600359
Merge into: lp:ubuntu/maverick/ureadahead
Diff against target: 46 lines (+19/-0)
3 files modified
conf/ureadahead-other.conf (+6/-0)
conf/ureadahead.conf (+6/-0)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp:~rsalveti/ubuntu/maverick/ureadahead/fix-600359
Reviewer Review Type Date Requested Status
Dave Walker 2010-11-25 Disapprove on 2010-12-03
Evan Broder 2010-08-18 Needs Information on 2010-11-25
Review via email: mp+32955@code.launchpad.net

Commit message

  * conf/ureadahead*.conf: only run ureadahead on systems with at least 512MB of ram. (LP: #600359)

Description of the change

Changing ureadahead initscript to avoid running ureadahead at systems with less than 512 MB of ram.

This is needed because ureadahead sets the tracing buffer to 128MB, and at a system with small amount of memory (Beagleboard) this can cause the boot to call the OOM, killing ureadahead and plymouthd.

Check bug 600359 for more details.

I decided to change only the initscript, instead of adding this restriction to the ureadahead code, because then the user can still run and test it if needed.

I also tried different memory thresholds, but didn't change the boot speed when comparing different bootcharts for BeagleBoard, so I just decided to avoid running it in this case.

To post a comment you must log in.
11. By Tim Gardner on 2010-08-20

Count the number of CPUs and divide buffer_size_kb by the number of CPUs.
Users should watch for instances of "mmiotrace has lost events" in dmesg to make
sure the trace buffers are not too small. The original value for
buffer_size_kb was chosen somewhat arbitrarily. Empirical testing
has shown that its large enough, so we don't actually know where the lower
boundary lies.
-LP: #491943

12. By Ricardo Salveti on 2010-08-24

conf/ureadahead*.conf: only run ureadahead on systems with at least
512MB of ram. (LP: #600359)

Evan Broder (broder) wrote :

This merge proposal references a bug which appears to have been fixed through an alternative approach. Is this merge still needed? If it is needed, please rebase the patch on the current version of lp:ubuntu/ureadahead. If it is no longer needed, please let us know so that we can remove this proposal, or feel free to delete the proposal yourself.

review: Needs Information
Dave Walker (davewalker) wrote :

Rejecting, as Ricardo states it's no longer required.

review: Disapprove

Unmerged revisions

12. By Ricardo Salveti on 2010-08-24

conf/ureadahead*.conf: only run ureadahead on systems with at least
512MB of ram. (LP: #600359)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'conf/ureadahead-other.conf'
2--- conf/ureadahead-other.conf 2009-12-21 23:20:02 +0000
3+++ conf/ureadahead-other.conf 2010-08-24 05:14:39 +0000
4@@ -16,4 +16,10 @@
5 # don't treat a missing pack file as an error either
6 normal exit 0 4
7
8+pre-start script
9+ # Just run on systems with at least ~512MB
10+ MEM=$(grep ^MemTotal /proc/meminfo | awk -F' ' '{print $2}')
11+ test $MEM -gt 500000 || { stop; exit 0; }
12+end script
13+
14 exec /sbin/ureadahead --daemon $MOUNTPOINT
15
16=== modified file 'conf/ureadahead.conf'
17--- conf/ureadahead.conf 2009-11-09 18:38:51 +0000
18+++ conf/ureadahead.conf 2010-08-24 05:14:39 +0000
19@@ -20,6 +20,12 @@
20 # Don't treat a normal exit after reading finishes as a failure
21 normal exit 0
22
23+pre-start script
24+ # Just run on systems with at least ~512MB
25+ MEM=$(grep ^MemTotal /proc/meminfo | awk -F' ' '{print $2}')
26+ test $MEM -gt 500000 || { stop; exit 0; }
27+end script
28+
29 exec /sbin/ureadahead --daemon
30
31 # Normally ureadahead will exit on its own when it finishes, unless it's
32
33=== modified file 'debian/changelog'
34--- debian/changelog 2010-08-20 12:19:31 +0000
35+++ debian/changelog 2010-08-24 05:14:39 +0000
36@@ -1,3 +1,10 @@
37+ureadahead (0.100.0-8) maverick; urgency=low
38+
39+ * conf/ureadahead*.conf: only run ureadahead on systems with at least
40+ 512MB of ram. (LP: #600359)
41+
42+ -- Ricardo Salveti de Araujo <ricardo.salveti@canonical.com> Tue, 24 Aug 2010 02:11:23 -0300
43+
44 ureadahead (0.100.0-7) maverick; urgency=low
45
46 * Count the number of CPUs and divide buffer_size_kb by the number of CPUs.

Subscribers

People subscribed via source and target branches

to all changes: