Merge lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742 into lp:ubuntu/maverick/qemu-kvm

Proposed by Ricardo Salveti
Status: Merged
Merge reported by: Dustin Kirkland 
Merged at revision: not available
Proposed branch: lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742
Merge into: lp:ubuntu/maverick/qemu-kvm
Diff against target: 95 lines (+75/-0)
3 files modified
debian/changelog (+10/-0)
debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch (+64/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~rsalveti/ubuntu/maverick/qemu-kvm/fix-610742
Reviewer Review Type Date Requested Status
Serge Hallyn Approve
Review via email: mp+31120@code.launchpad.net

Description of the change

debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch:
 Avoid showing unsupported syscall: 335 for pselect. This was fixed for
 lucid with the pselect patch, but upstream decided not to apply it as it
 it can't guaranty the atomicity for all distros. This patch is backported
 from upstream, as they decided to just remove the warn for it (LP: #610742)

To post a comment you must log in.
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, this looks good. It'll have a very short life-time, but
sounds worth having in the meantime.

Note that I don't have upload rights, so all I can do is say "I
approve" fwiw.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-07-26 15:04:23 +0000
3+++ debian/changelog 2010-07-28 07:07:43 +0000
4@@ -1,3 +1,13 @@
5+qemu-kvm (0.12.4+noroms-0ubuntu7) maverick; urgency=low
6+
7+ * debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch:
8+ Avoid showing unsupported syscall: 335 for pselect. This was fixed for
9+ lucid with the pselect patch, but upstream decided not to apply it as it
10+ it can't guaranty the atomicity for all distros. This patch is backported
11+ from upstream, as they decided to just remove the warn for it (LP: #610742)
12+
13+ -- Ricardo Salveti de Araujo <ricardo.salveti@canonical.com> Wed, 28 Jul 2010 02:56:04 -0300
14+
15 qemu-kvm (0.12.4+noroms-0ubuntu6) maverick; urgency=low
16
17 * New patch, arm-ignore-writes-of-perf-reg-cp15-with-crm-12, on ARMv7,
18
19=== added file 'debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch'
20--- debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch 1970-01-01 00:00:00 +0000
21+++ debian/patches/linux-user-do-not-warn-for-missing-pselect6.patch 2010-07-28 07:07:43 +0000
22@@ -0,0 +1,64 @@
23+From 9e42382fc14b999126f8cabb32761eb98153fd1b Mon Sep 17 00:00:00 2001
24+From: Riku Voipio <riku.voipio@nokia.com>
25+Date: Fri, 7 May 2010 12:28:05 +0000
26+Subject: [PATCH] linux-user: do not warn for missing pselect6
27+
28+Libc will fallback gracefully if pselect6 is not available. Thus put
29+pselect6 to nowarn until the atomicity issues of the original pselect6
30+patch are dealt with.
31+
32+Signed-off-by: Riku Voipio <riku.voipio@nokia.com>
33+Cc: Michael Casadevall <mcasadevall@ubuntu.com>
34+Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
35+---
36+ linux-user/syscall.c | 4 ++++
37+ 1 files changed, 4 insertions(+), 0 deletions(-)
38+
39+diff --git a/linux-user/syscall.c b/linux-user/syscall.c
40+index bca8f70..8222cb9 100644
41+--- a/linux-user/syscall.c
42++++ b/linux-user/syscall.c
43+@@ -5268,6 +5268,10 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
44+ }
45+ break;
46+ #endif
47++#ifdef TARGET_NR_pselect6
48++ case TARGET_NR_pselect6:
49++ goto unimplemented_nowarn;
50++#endif
51+ case TARGET_NR_symlink:
52+ {
53+ void *p2;
54+--
55+1.7.1
56+
57+From 7270547fe8d0d2c1d13fee592042208d4a82f73a Mon Sep 17 00:00:00 2001
58+From: Michael Casadevall <mcasadevall@ubuntu.com>
59+Date: Fri, 26 Mar 2010 15:25:10 +0000
60+Subject: [PATCH] linux-user: Add the syscall id for pselect6 on ARM
61+
62+As this is now supported in newer linux kernels.
63+
64+Signed-off-by: Michael Casadevall <mcasadevall@ubuntu.com>
65+Signed-off-by: Riku Voipio <riku.voipio@nokia.com>
66+Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
67+---
68+ linux-user/arm/syscall_nr.h | 2 +-
69+ 1 files changed, 1 insertions(+), 1 deletions(-)
70+
71+diff --git a/linux-user/arm/syscall_nr.h b/linux-user/arm/syscall_nr.h
72+index b1db341..79a216a 100644
73+--- a/linux-user/arm/syscall_nr.h
74++++ b/linux-user/arm/syscall_nr.h
75+@@ -338,7 +338,7 @@
76+ #define TARGET_NR_readlinkat (332)
77+ #define TARGET_NR_fchmodat (333)
78+ #define TARGET_NR_faccessat (334)
79+- /* 335 for pselect6 */
80++#define TARGET_NR_pselect6 (335)
81+ /* 336 for ppoll */
82+ #define TARGET_NR_unshare (337)
83+ #define TARGET_NR_set_robust_list (338)
84+--
85+1.7.1
86+
87
88=== modified file 'debian/patches/series'
89--- debian/patches/series 2010-07-26 15:04:23 +0000
90+++ debian/patches/series 2010-07-28 07:07:43 +0000
91@@ -5,3 +5,4 @@
92 scm-rights-fd.patch
93 fix-multiboot-compilation.patch
94 Detect-and-use-GCC-atomic-builtins-for-locking.patch
95+linux-user-do-not-warn-for-missing-pselect6.patch

Subscribers

People subscribed via source and target branches