Merge lp:~rsalveti/phablet-extras/ofono_data_state_tracking into lp:phablet-extras/ofono
Status: | Merged |
---|---|
Approved by: | Tony Espy |
Approved revision: | 53 |
Merged at revision: | 50 |
Proposed branch: | lp:~rsalveti/phablet-extras/ofono_data_state_tracking |
Merge into: | lp:phablet-extras/ofono |
Diff against target: |
71 lines (+37/-1) 2 files modified
debian/changelog (+7/-0) drivers/rilmodem/gprs.c (+30/-1) |
To merge this branch: | bzr merge lp:~rsalveti/phablet-extras/ofono_data_state_tracking |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tony Espy | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Dave Morley (community) | tested on maguro device | Approve | |
Review via email: mp+177505@code.launchpad.net |
Commit message
rilmodem/gprs.c: adding back state tracking for data network (only when ofono is already attached)
Description of the change
rilmodem/gprs.c: adding back state tracking for data network (only when ofono is already attached)
Adding back some of the logic that was removed when you fixed the roaming bug, as we need to track the data network status anyway (e.g when we get disconnected or when we start roaming).
To avoid a loop when notifying ofono, we only care to check different states if ofono_attached is true (which means we need to tell ofono if something changed). If the device is roaming, ofono_attached will be set to false at the second run, breaking the previous infinite loop logic.
Tested with maguro and I can always get attached, right after boot.
PASSED: Continuous integration, rev:51 jenkins. qa.ubuntu. com/job/ phablet- extras- ofono-ci/ 67/ jenkins. qa.ubuntu. com/job/ phablet- extras- ofono-saucy- armhf-ci/ 42 jenkins. qa.ubuntu. com/job/ phablet- extras- ofono-saucy- armhf-ci/ 42/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ phablet- extras- ofono-ci/ 67/rebuild
http://