Mir

Merge lp:~rsalveti/mir/fixing-libhybris-dependencies into lp:~mir-team/mir/trunk

Proposed by Ricardo Salveti
Status: Merged
Approved by: Robert Ancell
Approved revision: no longer in the source branch.
Merged at revision: 932
Proposed branch: lp:~rsalveti/mir/fixing-libhybris-dependencies
Merge into: lp:~mir-team/mir/trunk
Diff against target: 124 lines (+23/-22)
4 files modified
cmake/FindEGL.cmake (+0/-5)
cmake/FindGLESv2.cmake (+0/-5)
debian/control (+1/-1)
tools/setup-partial-armhf-chroot.sh (+22/-11)
To merge this branch: bzr merge lp:~rsalveti/mir/fixing-libhybris-dependencies
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Kevin DuBois (community) Approve
Thomas Voß Pending
Review via email: mp+178863@code.launchpad.net

Commit message

Just use libhardware instead of libhybris when building mir (avoid conflicts with egl/gles)

Description of the change

Just use libhardware instead of libhybris when building mir (avoid conflicts with egl/gles)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

looks good to me, if we can get this past jenkins. :) it will likely take some tinkering with this cmake file to find the libraries in the cross build. i can try teaching cmake to find the files somehow else for a bit tomorrow

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/FindEGL.cmake'
2--- cmake/FindEGL.cmake 2013-01-15 19:30:28 +0000
3+++ cmake/FindEGL.cmake 2013-08-07 03:45:36 +0000
4@@ -10,13 +10,8 @@
5 find_path(EGL_INCLUDE_DIR EGL/egl.h
6 HINTS ${PC_EGL_INCLUDEDIR} ${PC_EGL_INCLUDE_DIRS})
7
8-if (MIR_PLATFORM STREQUAL "android")
9-find_library(EGL_LIBRARY libEGL.so.1
10- HINTS /usr/lib/arm-linux-gnueabihf/libhybris-egl/)
11-else()
12 find_library(EGL_LIBRARY EGL
13 HINTS ${PC_EGL_LIBDIR} ${PC_EGL_LIBRARY_DIRS})
14-endif()
15
16 set(EGL_LIBRARIES ${EGL_LIBRARY})
17 set(EGL_INCLUDE_DIRS ${EGL_INCLUDE_DIR})
18
19=== modified file 'cmake/FindGLESv2.cmake'
20--- cmake/FindGLESv2.cmake 2013-01-15 19:30:28 +0000
21+++ cmake/FindGLESv2.cmake 2013-08-07 03:45:36 +0000
22@@ -10,13 +10,8 @@
23 find_path(GLESv2_INCLUDE_DIR GLES2/gl2.h
24 HINTS ${PC_GLESv2_INCLUDEDIR} ${PC_GLESv2_INCLUDE_DIRS})
25
26-if (MIR_PLATFORM STREQUAL "android")
27-find_library(GLESv2_LIBRARY libGLESv2.so.2
28- HINTS /usr/lib/arm-linux-gnueabihf/libhybris-egl/)
29-else()
30 find_library(GLESv2_LIBRARY GLESv2
31 HINTS ${PC_GLESv2_LIBDIR} ${PC_GLESv2_LIBRARY_DIRS})
32-endif()
33
34 set(GLESv2_LIBRARIES ${GLESv2_LIBRARY})
35 set(GLESv2_INCLUDE_DIRS ${GLESv2_INCLUDE_DIR})
36
37=== modified file 'debian/control'
38--- debian/control 2013-08-03 01:36:16 +0000
39+++ debian/control 2013-08-07 03:45:36 +0000
40@@ -26,7 +26,7 @@
41 libglm-dev,
42 libprotobuf-dev,
43 pkg-config,
44- libhybris-dev [armhf],
45+ libhardware-dev [armhf],
46 libgoogle-glog-dev,
47 liblttng-ust-dev,
48 libxkbcommon-dev,
49
50=== modified file 'tools/setup-partial-armhf-chroot.sh'
51--- tools/setup-partial-armhf-chroot.sh 2013-07-10 18:36:28 +0000
52+++ tools/setup-partial-armhf-chroot.sh 2013-08-07 03:45:36 +0000
53@@ -50,7 +50,6 @@
54 libboost-date-time1.53-dev
55 libboost-filesystem1.53-dev
56 libboost-program-options1.53-dev
57- libprotobuf-dev
58 libboost-chrono1.53.0
59 libboost-date-time1.53.0
60 libboost-filesystem1.53.0
61@@ -61,8 +60,9 @@
62 libboost-regex1.53-dev
63 libboost-regex1.53.0
64 libboost-program-options1.53.0
65- libhybris
66- libhybris-dev
67+ libhardware2
68+ libhardware-dev
69+ libhybris-common1
70 libandroid-properties1
71 libgflags2
72 libgflags-dev
73@@ -71,8 +71,21 @@
74 libicu48
75 libprotobuf7
76 libprotobuf-dev
77+ libegl1-mesa
78 libegl1-mesa-dev
79+ libgles2-mesa
80 libgles2-mesa-dev
81+ libglapi-mesa
82+ libffi6
83+ libdrm2
84+ libgbm1
85+ libxau6
86+ libxdmcp6
87+ libx11-6
88+ libx11-xcb1
89+ libxcb1
90+ libxcb-dri2-0
91+ libxcb-xfixes0
92 libxkbcommon0
93 libxkbcommon-dev
94 libumockdev-dev
95@@ -81,11 +94,16 @@
96 libuuid1
97 liblttng-ust-dev
98 liburcu-dev
99+ libudev1
100+ libwayland-client0
101+ libwayland-server0
102 uuid-dev
103 systemtap-sdt-dev
104 zlib1g)
105
106- declare -a PACKAGES_ALL=(libglm-dev)
107+ declare -a PACKAGES_ALL=(
108+ android-platform-headers
109+ libglm-dev)
110
111 #cleanup
112 for i in * ; do
113@@ -97,11 +115,4 @@
114
115 download_and_extract_packages PACKAGES_ARMHF armhf
116 download_and_extract_packages PACKAGES_ALL all
117-
118- #todo: we get egl/gles headers from the mesa packages, but should be pointing at the hybris libraries
119- #just rewrite the symlinks for now
120- rm ./usr/lib/arm-linux-gnueabihf/libEGL.so
121- rm ./usr/lib/arm-linux-gnueabihf/libGLESv2.so
122- ln -s libhybris-egl/libEGL.so.1 ./usr/lib/arm-linux-gnueabihf/libEGL.so
123- ln -s libhybris-egl/libGLESv2.so.2 ./usr/lib/arm-linux-gnueabihf/libGLESv2.so
124 popd > /dev/null

Subscribers

People subscribed via source and target branches