Merge lp:~rsalveti/firefox/disable-thumb2 into lp:firefox/trunk

Proposed by Ricardo Salveti on 2011-06-24
Status: Rejected
Rejected by: Rico Tzschichholz on 2017-10-17
Proposed branch: lp:~rsalveti/firefox/disable-thumb2
Merge into: lp:firefox/trunk
Diff against target: 39 lines (+8/-0)
2 files modified
debian/changelog (+4/-0)
debian/rules (+4/-0)
To merge this branch: bzr merge lp:~rsalveti/firefox/disable-thumb2
Reviewer Review Type Date Requested Status
Chris Coulson 2011-06-24 Pending
Review via email: mp+65758@code.launchpad.net

Description of the change

As described by bug 789198, THUMB2 breaks WebM functionality on ARM, and as side effect people can't use youtube even with html5 support.

This patch changes it in a way to make it easier to build with thumb2 again, so people can easily try the thumb2 enabled build to debug the issue.

To post a comment you must log in.

Unmerged revisions

892. By Ricardo Salveti on 2011-06-24

Disable THUMB2 support at ARM by default to have proper WebM support an
let users play html5 videos (LP: #789198)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-23 16:42:47 +0000
3+++ debian/changelog 2011-06-24 02:22:23 +0000
4@@ -52,6 +52,10 @@
5 - update debian/control.langpacks
6 - refresh debian/control
7
8+ [ Ricardo Salveti de Araujo <ricardo.salveti@linaro.org ]
9+ * Disable THUMB2 support at ARM by default to have proper WebM support an
10+ let users play html5 videos (LP: #789198)
11+
12 -- Chris Coulson <chris.coulson@canonical.com> Wed, 22 Jun 2011 23:53:29 +0100
13
14 firefox-trunk (6.0~a1~hg20110523r69965+nobinonly-0ubuntu1) oneiric; urgency=low
15
16=== modified file 'debian/rules'
17--- debian/rules 2011-06-18 20:05:02 +0000
18+++ debian/rules 2011-06-24 02:22:23 +0000
19@@ -21,6 +21,8 @@
20 MOZ_DEBUG ?= 0
21 # 1 = Disable optimizations
22 MOZ_NO_OPTIMIZE ?= 0
23+# 1 = Enable THUMB2 support when building for ARM
24+MOZ_THUMB2 ?= 0
25
26 # These are used for cross-compiling and for saving the configure script
27 # from having to guess our platform (since we know it already)
28@@ -248,9 +250,11 @@
29 ifeq (1,$(MOZ_DEBUG))
30 DEB_DEFINES += -DMOZ_DEBUG
31 endif
32+ifeq (1,$(MOZ_THUMB2))
33 ifneq (,$(findstring armel,$(DEB_HOST_ARCH)))
34 DEB_DEFINES += -DDEB_ENABLE_THUMB2
35 endif
36+endif
37 ifeq (1,$(MOZ_ENABLE_GLOBALMENU))
38 DEB_DEFINES += -DMOZ_ENABLE_GLOBALMENU
39 endif

Subscribers

People subscribed via source and target branches