webbrowser-app

Merge lp:~rpadovani/webbrowser-app/updateReadme into lp:webbrowser-app

  1. updateReadme
  2. Merge into trunk
Proposed by Riccardo Padovani
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 761
Merged at revision: 772
Proposed branch: lp:~rpadovani/webbrowser-app/updateReadme
Merge into: lp:webbrowser-app
Diff against target: 18 lines (+2/-2)
1 file modified
README (+2/-2)
To merge this branch: bzr merge lp:~rpadovani/webbrowser-app/updateReadme
Reviewer Review Type Date Requested Status
Olivier Tilloy Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+237671@code.launchpad.net

Commit message

Updated the README

Description of the change

Updated the README

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:760
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1155/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5689/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4002
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/354
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/354
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/354/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/354
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5360/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6941
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6941/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14358
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3371
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4329
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4329/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1155/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for your attention to detail, this README should have been updated long ago!

The changes in the path are obviously correct, but I don’t think the new paragraph about build dependencies is needed. In fact, for it to be correct you would need to list all the build deps as found in debian/control (see http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/debian/control). But the README file is meant to be as distro-agnostic as possible, so I don’t think we should list debian packages there (that would just be duplicating the information already available in debian/control).

review: Needs Fixing
lp:~rpadovani/webbrowser-app/updateReadme updated
761. By Riccardo Padovani

Removed dependencies from README

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Gotcha, thanks!

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:761
http://jenkins.qa.ubuntu.com/job/webbrowser-app-ci/1156/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5701
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4003
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-amd64-ci/355
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/355
        deb: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-armhf-ci/355/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/webbrowser-app-utopic-i386-ci/355
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5367
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6953
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6953/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14365
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3373
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4330
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4330/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1156/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2014-06-30 10:50:35 +0000
3+++ README 2014-10-08 22:47:15 +0000
4@@ -21,12 +21,12 @@
5 webbrowser-app can be run from the development branch without the need to
6 install any files. Just run:
7
8- $ ./src/app/webbrowser-app
9+ $ ./src/app/webbrowser/webbrowser-app
10
11 The executable accepts command line switches and parameters. To find out which,
12 just run:
13
14- $ ./src/app/webbrowser-app --help
15+ $ ./src/app/webbrowser/webbrowser-app --help
16
17
18 = Unit tests =

Subscribers

People subscribed via source and target branches

to status/vote changes: