Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Thanks for the suggestion Olivier, I implemented that.

BTW, we should take a look to the function looksLikeAUrl(). It checks if tld.length is < 5 (.match(/\.[a-zA-Z]{2,4}$/))
Now TLD could be very long[0], so we should remove that restriction (also if they aren't used so much at the moment, the only one I know is com.google)

[0]: https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#ICANN-era_generic_top-level_domains

« Back to merge proposal