Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Bill Filler (bfiller) wrote :

I found some problems with the Homepage setting after clicking on it:
1) autocaps should be turned off on the field (Qt.ImhNoAutoUppercase)
2) predictive text should be turned off on the field (Qt.ImhNoPredictiveText)
3) set the hint for url field so the keyboard will display .com keys (Qt.ImhUrlCharactersOnly) - actually doing this might mean you don't need 1) and 2) as it might happen automatically
4) Upon displaying the dialog you should request focus on the input field with the caret at the end of the line. This will cause osk to appear by default saving the user an extra click
5) after making a change to a new site and pressing "Save", it is not saved and does not appear in the Homepage field in the main Settings.

There is no visual difference between "Privacy" and "Reset browser settings", but one brings you to another page (Privacy) and the other executes an action immediately. I believe Privacy should have a expansion arrow (like Privacy >) such that it's clear it leads you to another page.

review: Needs Fixing

« Back to merge proposal