Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

> - Instead of having searchEngineContainer and privacyContainer, we could have
> one single subpageContainer, as we will never have two subpages instantiated
> at the same time anyway.

And most importantly, that would allow us to set the visibility of the main settings page accordingly (i.e. hide it whenever there’s a subpage overlaid on top of it).

« Back to merge proposal