Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

201 + subText: settingsObject.searchEngine

this is the filename (minus the .xml extension), not very user friendly. Instead, the subtext should have the display name of the engine, for which we need to instantiate a SearchEngine object:

    SearchEngine {
        id: currentSearchEngine
        filename: settingsObject.searchEngine
    }
    subText: currentSearchEngine.name

review: Needs Fixing

« Back to merge proposal