A bunch of additional comments, in no particular order:
- Can the 'use strict' statement go after the license and copyright header? It looks weird before it…
- We need to make the current webview invisible while the settings page is visible, to avoid redrawing it uselessly (note that this isn’t done for the history view, but it should, really).
Setting 'visible: !settingsContainer.visible' on the top-level Item (line 108) that contains the chrome and the webviews should probably be good enough.
As a side note, run "QSG_VISUALIZE=overdraw ./src/app/webbrowser/webbrowser-app" to visualize when several opaque items overlap.
- Clicking "Reset browser settings" when a value has just been changed won’t update the corresponding entry in the view (try e.g. to change the homepage and just after that reset the settings)
- In the visual spec, it looks like all items have a thin divider at the bottom, so the "Reset browser settings" one probably needs one as well
- The new unit test looks good, can you please also test the emission of the signal, by adding a QSignalSpy?
A bunch of additional comments, in no particular order:
- Can the 'use strict' statement go after the license and copyright header? It looks weird before it…
- We need to make the current webview invisible while the settings page is visible, to avoid redrawing it uselessly (note that this isn’t done for the history view, but it should, really). ner.visible' on the top-level Item (line 108) that contains the chrome and the webviews should probably be good enough. overdraw ./src/app/ webbrowser/ webbrowser- app" to visualize when several opaque items overlap.
Setting 'visible: !settingsContai
As a side note, run "QSG_VISUALIZE=
- Clicking "Reset browser settings" when a value has just been changed won’t update the corresponding entry in the view (try e.g. to change the homepage and just after that reset the settings)
- In the visual spec, it looks like all items have a thin divider at the bottom, so the "Reset browser settings" one probably needs one as well
- The new unit test looks good, can you please also test the emission of the signal, by adding a QSignalSpy?
-