Code review comment for lp:~rpadovani/webbrowser-app/settings-page

Revision history for this message
Olivier Tilloy (osomon) wrote :

browser.allowOpenInBackgroundTab is a string, not a boolean, so the following won’t work as expected:

    control: Switch {
        checked: browser.allowOpenInBackgroundTab
        onClicked: browser.allowOpenInBackgroundTab = checked;
    }

Instead, you’ll need to check that either the value is "true", or it’s "default" and the form factor is desktop.

review: Needs Fixing

« Back to merge proposal