webbrowser-app

Merge lp:~rpadovani/webbrowser-app/1378975 into lp:webbrowser-app

1378975
Merge into trunk

Proposed by Riccardo Padovani on 2014-10-08

Status:

Merged

Approved by:

Olivier Tilloy on 2014-10-09

Approved revision:

762

Merged at revision:

771

Proposed branch:

lp:~rpadovani/webbrowser-app/1378975

Merge into:

lp:webbrowser-app

Diff against target:

16 lines (+4/-2)

1 file modified

src/app/webbrowser/Chrome.qml (+4/-2)

To merge this branch:

bzr merge lp:~rpadovani/webbrowser-app/1378975

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration		Needs Fixing on 2014-10-09
Olivier Tilloy		2014-10-08	Approve on 2014-10-09
Review via email: mp+237661@code.launchpad.net

Commit message

Fixed #1378975 - Fast double click on menu button opens menu twice

Description of the change

Fixed #1378975 - Fast double click on menu button opens menu twice

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-08:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1154/rebuild

review: Approve (continuous-integration)

Revision history for this message

Olivier Tilloy (osomon) wrote on 2014-10-08:

Thanks for the bug report and your work on this!

While your patch works, it can be simplified: there is no need to introduce a new property to check whether there is already a menu being open. Instead, just do the following:

    onTriggered: {
        if (!internal.openDrawer) {
            internal.openDrawer = drawerComponent.createObject(chrome)
            internal.openDrawer.opened = true
        }
    }

(internal.openDrawer gets reset to null as soon as the menu is closed)

review: Needs Fixing

lp:~rpadovani/webbrowser-app/1378975 updated on 2014-10-08

761. By Riccardo Padovani on 2014-10-08: Better implementation of the fix

Revision history for this message

Riccardo Padovani (rpadovani) wrote on 2014-10-08:

You're totally right, thanks for the suggestion :-)

Updated!

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1157/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Olivier Tilloy (osomon) wrote on 2014-10-09:

That looks good, thanks!
Could you please revert the meaningless changes to webbrowser-app.pot ?

lp:~rpadovani/webbrowser-app/1378975 updated on 2014-10-09

762. By Riccardo Padovani on 2014-10-09: Revert unwanted changes

Revision history for this message

Riccardo Padovani (rpadovani) wrote on 2014-10-09:

Done, sorry, I alwasy forget that bzr by default commit all files :/

Revision history for this message

Olivier Tilloy (osomon) wrote on 2014-10-09:

Thanks!

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1161/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1162/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1163/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1165/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-10-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/webbrowser-app-ci/1167/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Riccardo Padovani

Ubuntu Phablet Team

to status/vote changes:

Rachel Liu

1	=== modified file 'src/app/webbrowser/Chrome.qml'
2	--- src/app/webbrowser/Chrome.qml 2014-10-02 13:22:13 +0000
3	+++ src/app/webbrowser/Chrome.qml 2014-10-09 07:37:48 +0000
4	@@ -143,8 +143,10 @@
5	}
6
7	onTriggered: {
8	- internal.openDrawer = drawerComponent.createObject(chrome)
9	- internal.openDrawer.opened = true
10	+ if (!internal.openDrawer) {
11	+ internal.openDrawer = drawerComponent.createObject(chrome)
12	+ internal.openDrawer.opened = true
13	+ }
14	}
15	}
16	}